+ isdn4linux-siemens-gigaset-drivers-logging-usage.patch added to -mm tree
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 12 lines
(quoted diff) +5
-5- struct semaphore sem; /* locks this structure: */ - /* connected is not changed, */ - /* hardware_up is not changed, */ - /* MState is not changed to or from - MS_LOCKED */ + struct semaphore sem; /* locks this structure: + * connected is not changed, + * hardware_up is not changed, + * MState is not changed to or from + * MS_LOCKED */
please consider turning this into a mutex
Quoted 1 line · Arjan van de Ven
Quoted 1 line
(quoted diff) +1
-0+ struct semaphore sem; /* locks this structure:
[...]
Quoted 2 lines
please consider turning this into a mutex
Your wish is our command. Consider it already done. :-)
See isdn4linux-siemens-gigaset-drivers-mutex-conversion.patch in the same series.
Regards
Tilman
Signature · 4 lines
Tilman Schmidt E-Mail: [email protected] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
Quoted 9 lines · Tilman Schmidt
Quoted 1 line · Arjan van de Ven
Quoted 1 line
(quoted diff) +1
-0+ struct semaphore sem; /* locks this structure:[...]
Quoted 2 lines
please consider turning this into a mutex
Your wish is our command. Consider it already done. :-)
great!
apologies for missing that; that's what you get for trusting mail filters to trigger on patch fragments ;(
Quoted 6 lines · Arjan van de Ven
Quoted 5 lines · Tilman Schmidt
Quoted 1 line · Arjan van de Ven
Quoted 1 line
(quoted diff) +1
-0+ struct semaphore sem; /* locks this structure:[...]
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
please consider turning this into a mutex
Your wish is our command. Consider it already done. :-)
great!
apologies for missing that; that's what you get for trusting mail filters to trigger on patch fragments ;(
No trouble. Happens to the best of us.
Thanks for the time and effort you are putting into all this. I appreciate it.
Regards
Tilman
--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)