the overdue removal of RAW1394_REQ_ISO_{LISTEN,SEND}
RFC PATCH 1/1 the overdue removal of RAW1394_REQ_ISO_{LISTEN,SEND}
This patch contains the overdue removal of the RAW1394_REQ_ISO_SEND and RAW1394_REQ_ISO_LISTEN request types plus all support code for them.
---
Documentation/feature-removal-schedule.txt | 9 -- drivers/ieee1394/highlevel.c | 15 --- drivers/ieee1394/highlevel.h | 4 drivers/ieee1394/ieee1394_core.c | 2 drivers/ieee1394/ieee1394_transactions.c | 30 ------- drivers/ieee1394/ieee1394_transactions.h | 3 drivers/ieee1394/raw1394.c | 88 --------------------- drivers/ieee1394/raw1394.h | 4 8 files changed, 3 insertions(+), 152 deletions(-)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0 -9
@@ -48,15 +48,6 @@ --------------------------- -What: raw1394: requests of type RAW1394_REQ_ISO_SEND, RAW1394_REQ_ISO_LISTEN -When: November 2005 -Why: Deprecated in favour of the new ioctl-based rawiso interface, which is - more efficient. You should really be using libraw1394 for raw1394 - access anyway. -Who: Jody McIntyre <[email protected]> - ---------------------------- - What: Video4Linux API 1 ioctls and video_decoder.h from Video devices. When: July 2006 Why: V4L1 AP1 was replaced by V4L2 API. during migration from 2.4 to 2.6
drivers/ieee1394/raw1394.h renamed from drivers/ieee1394/raw1394.h.old +2 -2
@@ -17,11 +17,11 @@#define RAW1394_REQ_ASYNC_WRITE 101#define RAW1394_REQ_LOCK 102#define RAW1394_REQ_LOCK64 103 -#define RAW1394_REQ_ISO_SEND 104 +/* removed: RAW1394_REQ_ISO_SEND 104 */ #define RAW1394_REQ_ASYNC_SEND 105#define RAW1394_REQ_ASYNC_STREAM 106 -#define RAW1394_REQ_ISO_LISTEN 200 +/* removed: RAW1394_REQ_ISO_LISTEN 200 */ #define RAW1394_REQ_FCP_LISTEN 201#define RAW1394_REQ_RESET_BUS 202#define RAW1394_REQ_GET_ROM 203
drivers/ieee1394/raw1394.c renamed from drivers/ieee1394/raw1394.c.old +0 -88
112 lines not on this page · raw message
drivers/ieee1394/highlevel.h renamed from drivers/ieee1394/highlevel.h.old +1 -3
@@ -152,11 +152,9 @@ u64 start);/* -* Enable or disable receving a certain isochronous channel through the +* Disable receving a certain isochronous channel through the * iso_receive op. */ -int hpsb_listen_channel (struct hpsb_highlevel *hl,struct hpsb_host *host, -unsigned int channel);void hpsb_unlisten_channel (struct hpsb_highlevel *hl,struct hpsb_host *host,unsigned int channel);
drivers/ieee1394/highlevel.c renamed from drivers/ieee1394/highlevel.c.old +0 -15
@@ -439,21 +439,6 @@return retval; } -int hpsb_listen_channel (struct hpsb_highlevel *hl,struct hpsb_host *host, -unsigned int channel) -{ -if (channel >63 ) { -HPSB_ERR ("%s called with invalid channel" , __FUNCTION__); -return -EINVAL ; - } - -if (host->iso_listen_count[channel]++ ==0 ) { -return host->driver->devctl (host,ISO_LISTEN_CHANNEL , channel); - } - -return 0 ; -} -void hpsb_unlisten_channel (struct hpsb_highlevel *hl,struct hpsb_host *host,unsigned int channel) {
drivers/ieee1394/ieee1394_core.c renamed from drivers/ieee1394/ieee1394_core.c.old +0 -2
@@ -1223,7 +1223,6 @@EXPORT_SYMBOL (hpsb_make_lockpacket);EXPORT_SYMBOL (hpsb_make_lock64packet);EXPORT_SYMBOL (hpsb_make_phypacket); -EXPORT_SYMBOL (hpsb_make_isopacket);EXPORT_SYMBOL (hpsb_read);EXPORT_SYMBOL (hpsb_write);EXPORT_SYMBOL (hpsb_packet_success);
@@ -1234,7 +1233,6 @@EXPORT_SYMBOL (hpsb_register_addrspace);EXPORT_SYMBOL (hpsb_unregister_addrspace);EXPORT_SYMBOL (hpsb_allocate_and_register_addrspace); -EXPORT_SYMBOL (hpsb_listen_channel);EXPORT_SYMBOL (hpsb_unlisten_channel);EXPORT_SYMBOL (hpsb_get_hostinfo);EXPORT_SYMBOL (hpsb_create_hostinfo);
drivers/ieee1394/ieee1394_transactions.h renamed from drivers/ieee1394/ieee1394_transactions.h.old +0 -3
@@ -20,9 +20,6 @@ octlet_t arg);struct hpsb_packet *hpsb_make_phypacket (struct hpsb_host *host,quadlet_t data) ; -struct hpsb_packet *hpsb_make_isopacket (struct hpsb_host *host, -int length,int channel, -int tag,int sync);struct hpsb_packet *hpsb_make_writepacket (struct hpsb_host *host,nodeid_t node,u64 addr,quadlet_t *buffer,size_t length); struct hpsb_packet *hpsb_make_streampacket(struct hpsb_host *host, u8 *buffer,
drivers/ieee1394/ieee1394_transactions.c renamed from drivers/ieee1394/ieee1394_transactions.c.old +0 -30
@@ -79,18 +79,6 @@ packet->expect_response =1 ; } -static void fill_iso_packet (struct hpsb_packet *packet,int length,int channel, -int tag,int sync) -{ - packet->header[0 ] = (length <<16 ) | (tag <<14 ) | (channel <<8 ) - | (TCODE_ISO_DATA <<4 ) | sync; - - packet->header_size =4 ; - packet->data_size = length; - packet->type = hpsb_iso; - packet->tcode =TCODE_ISO_DATA ; -} -static void fill_phy_packet (struct hpsb_packet *packet,quadlet_t data) { packet->header[0 ] = data;
@@ -446,24 +434,6 @@return p; } -struct hpsb_packet *hpsb_make_isopacket (struct hpsb_host *host, -int length,int channel, -int tag,int sync) -{ -struct hpsb_packet *p; - - p =hpsb_alloc_packet (length); -if (!p) -return NULL ; - - p->host = host; -fill_iso_packet (p, length, channel, tag, sync); - - p->generation =get_hpsb_generation (host); - -return p; -} -/* * FIXME - these functions should probably read from / write to user space to * avoid in kernel buffers for user space callers
Quoted 5 lines · Adrian Bunk
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.Signed-off-by Adrian Bunk <[email protected]>
NAK if my vote is worth $.02. ieee1394 has been broken since 2.6.13-rc1, and apparently no one cares. I have a firewire movie camera I haven't been able to use since then. A Sony DVR-TVR460.
However, since my vote isn't worth a bucket of warm spit here, I do hope that when you are done, my camera can be used with linux again. Its been about 9 months now, the baby is due.
Quoted 302 lines
---
Documentation/feature-removal-schedule.txt | 9 -- drivers/ieee1394/highlevel.c | 15 --- drivers/ieee1394/highlevel.h | 4 drivers/ieee1394/ieee1394_core.c | 2 drivers/ieee1394/ieee1394_transactions.c | 30 ------- drivers/ieee1394/ieee1394_transactions.h | 3 drivers/ieee1394/raw1394.c | 88 --------------------- drivers/ieee1394/raw1394.h | 4 8 files changed, 3 insertions(+), 152 deletions(-)---
linux-2.6.17-rc1-mm1-full/Documentation/feature-removal-schedule.txt.
old 2006-04-06 22:45:55.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/Documentation/feature-removal-schedule.txt2006-04-06 22:46:04.000000000 +0200 @@ -48,15 +48,6 @@---------------------------
-What: raw1394: requests of type
RAW1394_REQ_ISO_SEND,RAW1394_REQ_ISO_LISTEN-When: November 2005
-Why: Deprecated in favour of the new ioctl-based rawiso interface,
which is - more efficient. You should really be using libraw1394 for
raw1394 - access anyway.Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0
-4-Who: Jody McIntyre <[email protected]> - ---------------------------- -What: Video4Linux API 1 ioctls and
video_decoder.hfrom Video
devices. When: July 2006
Why: V4L1 AP1 was replaced by V4L2 API. during migration from 2.4 to
2.6 ---
linux-2.6.17-rc1-mm1-full/drivers/ieee1394/raw1394.h.old 2006-04-06
22:44:51.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/raw1394.h2006-04-06
22:45:44.000000000 +0200 @@ -17,11 +17,11 @@#define RAW1394_REQ_ASYNC_WRITE 101 #define RAW1394_REQ_LOCK 102 #define RAW1394_REQ_LOCK64 103drivers/ieee1394/raw1394.h renamed from drivers/ieee1394/raw1394.h.old +1
-1-#define RAW1394_REQ_ISO_SEND 104 +/* removed: RAW1394_REQ_ISO_SEND 104 */ #define
RAW1394_REQ_ASYNC_SEND105
#defineRAW1394_REQ_ASYNC_STREAM106drivers/ieee1394/raw1394.h renamed from drivers/ieee1394/raw1394.h.old +1
-1-#define RAW1394_REQ_ISO_LISTEN 200 +/* removed: RAW1394_REQ_ISO_LISTEN 200 */ #define RAW1394_REQ_FCP_LISTEN 201 #define RAW1394_REQ_RESET_BUS 202 #define RAW1394_REQ_GET_ROM 203---
linux-2.6.17-rc1-mm1-full/drivers/ieee1394/raw1394.c.old 2006-04-06
22:46:15.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/raw1394.c2006-04-06
22:47:11.000000000 +0200 @@ -636,43 +636,6 @@return sizeof(struct raw1394_request); }-static void
handle_iso_listen(struct file_info *fi, struct pending_request *req)-{drivers/ieee1394/raw1394.c renamed from drivers/ieee1394/raw1394.c.old +0
-35-int channel = req->req.misc; - -if ((channel >63 ) || (channel <-64 )) { - req->req.error =RAW1394_ERROR_INVALID_ARG ; - }else if (channel >=0 ) { -/* allocate channel req.misc */ -if (fi->listen_channels & (1ULL << channel)) { - req->req.error =RAW1394_ERROR_ALREADY ; - }else { -if (hpsb_listen_channel - (&raw1394_highlevel, fi->host, channel)) { - req->req.error =RAW1394_ERROR_ALREADY ; - }else { - fi->listen_channels |=1ULL << channel; - fi->iso_buffer =int2ptr (req->req.recvb); - fi->iso_buffer_length = req->req.length; - } - } - }else { -/* deallocate channel (one's complement neg) req.misc */ - channel = ~channel; - -if (fi->listen_channels & (1ULL << channel)) { -hpsb_unlisten_channel (&raw1394_highlevel, fi->host, - channel); - fi->listen_channels &= ~(1ULL << channel); - }else { - req->req.error =RAW1394_ERROR_INVALID_ARG ; - } - } - - req->req.length =0 ; -queue_complete_req (req); -} -static void handle_fcp_listen(struct
file_info*fi, structpending_request *req) { if (req->req.misc) {drivers/ieee1394/raw1394.c renamed from drivers/ieee1394/raw1394.c.old +0
-42@@ -846,50 +809,6 @@return sizeof (struct raw1394_request ); } -static int handle_iso_send (struct file_info *fi,struct pending_request *req, - int channel) -{ -unsigned long flags; -struct hpsb_packet *packet; - - packet =hpsb_make_isopacket (fi->host, req->req.length, channel & 0x3f, - (req->req.misc >> 16) & 0x3, - req->req.misc &0xf ); -if (!packet) -return -ENOMEM ; - - packet->speed_code = req->req.address &0x3 ; - - req->packet = packet; - -if (copy_from_user (packet->data,int2ptr (req->req.sendb), - req->req.length)) { - req->req.error =RAW1394_ERROR_MEMFAULT ; - req->req.length =0 ; -queue_complete_req (req); -return sizeof (struct raw1394_request ); - } - - req->req.length =0 ; -hpsb_set_packet_complete_task (packet, - (void (*)(void *))queue_complete_req, - req); - -spin_lock_irqsave (&fi->reqlists_lock, flags); -list_add_tail (&req->list, &fi->req_pending); -spin_unlock_irqrestore (&fi->reqlists_lock, flags); - -/* Update the generation of the packet just before sending. */ - packet->generation = req->req.generation; - -if (hpsb_send_packet (packet) <0 ) { - req->req.error =RAW1394_ERROR_SEND_ERROR ; -queue_complete_req (req); - } - -return sizeof (struct raw1394_request ); -} -static int handle_async_send(struct
file_info*fi, structpending_request *req) { unsigned long flags;drivers/ieee1394/raw1394.c renamed from drivers/ieee1394/raw1394.c.old +0
-8@@ -2272,9 +2191,6 @@queue_complete_req (req);return sizeof (struct raw1394_request ); -case RAW1394_REQ_ISO_SEND : -return handle_iso_send (fi, req, node); -case RAW1394_REQ_ARM_REGISTER :return arm_register (fi, req);@@ -2290,10 +2206,6 @@case RAW1394_REQ_RESET_NOTIFY :return reset_notification (fi, req); -case RAW1394_REQ_ISO_LISTEN : -handle_iso_listen (fi, req); -return sizeof (struct raw1394_request ); -case RAW1394_REQ_FCP_LISTEN :handle_fcp_listen (fi, req);return sizeof (struct raw1394_request ); ---linux-2.6.17-rc1-mm1-full/drivers/ieee1394/highlevel.h.old 2006-04-06
22:55:51.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/highlevel.h2006-04-06
22:56:09.000000000 +0200 @@ -152,11 +152,9 @@u64 start);/*
- * Enable or disable receving a certain isochronous channel through the + * Disable receving a certain isochronous channel through the *iso_receiveop.
*/
-int hpsb_listen_channel(structhpsb_highlevel*hl, structhpsb_host
*host, - unsigned int channel);
voidhpsb_unlisten_channel(struct hpsb_highlevel *hl, struct hpsb_host *host, unsigned int channel);---
linux-2.6.17-rc1-mm1-full/drivers/ieee1394/highlevel.c.old 2006-04-06
22:56:17.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/highlevel.c2006-04-06
22:56:22.000000000 +0200 @@ -439,21 +439,6 @@return retval; }-int hpsb_listen_channel(struct
hpsb_highlevel*hl, structhpsb_host
*host, - unsigned int channel)drivers/ieee1394/highlevel.c renamed from drivers/ieee1394/highlevel.c.old +0
-3-{ -if (channel >63 ) { - HPSB_ERR("%s called with invalid channel",
__FUNCTION__); - return-EINVAL;drivers/ieee1394/highlevel.c renamed from drivers/ieee1394/highlevel.c.old +0
-4- } - -if (host->iso_listen_count[channel]++ ==0 ) { - return host->driver->devctl(host, ISO_LISTEN_CHANNEL,channel); - }
drivers/ieee1394/highlevel.c renamed from drivers/ieee1394/highlevel.c.old +0
-4- -return 0 ; -} -void
hpsb_unlisten_channel(struct hpsb_highlevel *hl, struct hpsb_host *host, unsigned int channel)
{
---
linux-2.6.17-rc1-mm1-full/drivers/ieee1394/ieee1394_core.c.old 2006-0
4-06 22:56:30.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/ieee1394_core.c2006-04-06
22:56:48.000000000 +0200 @@ -1223,7 +1223,6 @@EXPORT_SYMBOL(hpsb_make_lockpacket);EXPORT_SYMBOL(hpsb_make_lock64packet);EXPORT_SYMBOL(hpsb_make_phypacket); -EXPORT_SYMBOL(hpsb_make_isopacket);EXPORT_SYMBOL(hpsb_read);EXPORT_SYMBOL(hpsb_write);EXPORT_SYMBOL(hpsb_packet_success);drivers/ieee1394/ieee1394_core.c renamed from drivers/ieee1394/ieee1394_core.c.old +0
-2@@ -1234,7 +1233,6 @@EXPORT_SYMBOL (hpsb_register_addrspace);EXPORT_SYMBOL (hpsb_unregister_addrspace);EXPORT_SYMBOL (hpsb_allocate_and_register_addrspace); -EXPORT_SYMBOL (hpsb_listen_channel);EXPORT_SYMBOL (hpsb_unlisten_channel);EXPORT_SYMBOL (hpsb_get_hostinfo);EXPORT_SYMBOL (hpsb_create_hostinfo); ---linux-2.6.17-rc1-mm1-full/drivers/ieee1394/ieee1394_transactions.h.ol
d 2006-04-06 22:56:59.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/ieee1394_transactions.h20
06-04-06 22:57:03.000000000 +0200 @@ -20,9 +20,6 @@octlet_t arg); struct hpsb_packet *hpsb_make_phypacket(struct hpsb_host *host, quadlet_t data) ;drivers/ieee1394/ieee1394_transactions.h renamed from drivers/ieee1394/ieee1394_transactions.h.old +0
-3-struct hpsb_packet *hpsb_make_isopacket (struct hpsb_host *host, -int length,int channel, -int tag,int sync);struct
hpsb_packet*hpsb_make_writepacket(structhpsb_host*host,nodeid_tnode, u64 addr,quadlet_t*buffer,size_tlength); structhpsb_packet*hpsb_make_streampacket(structhpsb_host*host, u8 *buffer, --- linux-2.6.17-rc1-mm1-full/drivers/ieee1394/ieee1394_transactions.c.ol
d 2006-04-06 22:57:11.000000000 +0200 +++linux-2.6.17-rc1-mm1-full/drivers/ieee1394/ieee1394_transactions.c20
06-04-06 22:58:21.000000000 +0200 @@ -79,18 +79,6 @@packet->expect_response = 1; }-static void fill_iso_packet(struct
hpsb_packet*packet, int length,
int channel, - int tag, int sync)drivers/ieee1394/ieee1394_transactions.c renamed from drivers/ieee1394/ieee1394_transactions.c.old +0
-10-{ - packet->header[0 ] = (length <<16 ) | (tag <<14 ) | (channel <<8 ) - | (TCODE_ISO_DATA <<4 ) | sync; - - packet->header_size =4 ; - packet->data_size = length; - packet->type = hpsb_iso; - packet->tcode =TCODE_ISO_DATA ; -} -static void fill_phy_packet(struct
hpsb_packet*packet,quadlet_tdata) { packet->header[0] = data;drivers/ieee1394/ieee1394_transactions.c renamed from drivers/ieee1394/ieee1394_transactions.c.old +0
-18@@ -446,24 +434,6 @@return p; } -struct hpsb_packet *hpsb_make_isopacket (struct hpsb_host *host, -int length,int channel, -int tag,int sync) -{ -struct hpsb_packet *p; - - p =hpsb_alloc_packet (length); -if (!p) -return NULL ; - - p->host = host; -fill_iso_packet (p, length, channel, tag, sync); - - p->generation =get_hpsb_generation (host); - -return p; -} -/* * FIXME - these functions should probably read from / write to user space to * avoid in kernel buffers for user space callers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 7 lines
Cheers, Gene People having trouble with vz bouncing email to me should add the word 'online' between the 'verizon', and the dot which bypasses vz's stupid bounce rules. I do use spamassassin too. :-) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2006 by Maurice Eugene Heskett, all rights reserved.
Quoted 10 lines · Gene Heskett
Quoted 5 lines · Adrian Bunk
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.Signed-off-by Adrian Bunk <[email protected]>NAK if my vote is worth $.02. ieee1394 has been broken since 2.6.13-rc1, and apparently no one cares. I have a firewire movie camera I haven't been able to use since then. A Sony DVR-TVR460.
I doubt this has anything to do with your problem.
It is unfortunate that no one responded to your bug report. Try filing it in bugzilla.
Lee
Quoted 8 lines · Lee Revell
Quoted 7 lines · Gene Heskett
Quoted 5 lines · Adrian Bunk
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.Signed-off-by Adrian Bunk <[email protected]>
Quoted 9 lines
Quoted 3 lines
NAK if my vote is worth $.02. ieee1394 has been broken since 2.6.13-rc1, and apparently no one cares. I have a firewire movie camera I haven't been able to use since then. A Sony DVR-TVR460.
I doubt this has anything to do with your problem.
It is unfortunate that no one responded to your bug report. Try filing it in bugzilla.
Andrew fwd'd it to the 1394-devel list, but its since been swept under the rug. Like the only one home is the receptionist or ??
I'm watching that list, but its pretty dead.
Quoted 1 line
Lee
Signature · 7 lines
Cheers, Gene People having trouble with vz bouncing email to me should add the word 'online' between the 'verizon', and the dot which bypasses vz's stupid bounce rules. I do use spamassassin too. :-) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2006 by Maurice Eugene Heskett, all rights reserved.
Quoted 9 lines · Gene Heskett
Quoted 8 lines · Lee Revell
Quoted 7 lines · Gene Heskett
Quoted 5 lines · Adrian Bunk
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.Signed-off-by Adrian Bunk <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
NAK if my vote is worth $.02. ieee1394 has been broken since 2.6.13-rc1, and apparently no one cares. I have a firewire movie camera I haven't been able to use since then. A Sony DVR-TVR460.
I doubt this has anything to do with your problem.
It is unfortunate that no one responded to your bug report. Try filing it in bugzilla.
I went to the 1394 site a few mnutes ago, and it has no link to bugzilla. Which one were you referring to?
Quoted 6 lines
Andrew fwd'd it to the 1394-devel list, but its since been swept under the rug. Like the only one home is the receptionist or ??
I'm watching that list, but its pretty dead.
Quoted 1 line
Lee
Signature · 7 lines
Cheers, Gene People having trouble with vz bouncing email to me should add the word 'online' between the 'verizon', and the dot which bypasses vz's stupid bounce rules. I do use spamassassin too. :-) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2006 by Maurice Eugene Heskett, all rights reserved.
Quoted 9 lines · Gene Heskett
Quoted 5 lines
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.Signed-off-by Adrian Bunk <[email protected]>NAK if my vote is worth $.02. ieee1394 has been broken since 2.6.13-rc1, and apparently no one cares. I have a firewire movie camera I haven't been able to use since then. A Sony DVR-TVR460.
You may help by narrowing it down to exact 2.6.x[-rcY] where it broke. --
vda
Quoted 5 lines · Denis Vlasenko
Quoted 4 lines · Gene Heskett
Quoted 4 lines
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Adrian Bunk <[email protected]>NAK if my vote is worth $.02. ieee1394 has been broken since 2.6.13-rc1, and apparently no one cares. I have a firewire movie camera I haven't been able to use since then. A Sony DVR-TVR460.
You may help by narrowing it down to exact 2.6.x[-rcY] where it broke.
Apparently it broke with the commits that came in between 2.6.12 and 2.6.13-rc1.
I can't get any closer than that, and someone else has also commented that this is when it died. I hadn't needed it between may-june of last year and now, so I hadn't dug out the camera and tested it until the missus asked if I could make dvd's of some of her vhs stuff since the vhs player is on its last legs, not from head wear, but something on the board requires a healthy slap in the chops to make it work after its been off for a few weeks.
I was going to use the camera as a transcoder between the sloppily timed ntsc, and the firewire port. Now it locks kino up tighter than a drum the minute you select the capture screen. You have to click on the close button, and wait for the x server to ask you if you want to stop the process since it isn't responding. But that once done, seems to clean up the mess nicely.
Quoted 2 lines
--
vda
Signature · 7 lines
Cheers, Gene People having trouble with vz bouncing email to me should add the word 'online' between the 'verizon', and the dot which bypasses vz's stupid bounce rules. I do use spamassassin too. :-) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2006 by Maurice Eugene Heskett, all rights reserved.
Quoted 1 line · Adrian Bunk
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.
[...]
I am not familiar with the isochronous part of Linux' 1394 software stack, so I can't comment whether there are high-profile applications which still did not migrate away from this interface, or did so only recently.
However I have a few remarks about this patch:
1. You are not only removing the two ioctls but also two EXPORTs and their implementations, i.e. hpsb_listen_channel() and hpsb_make_isopacket().
1.a Nobody scheduled to remove these EXPORTs.
1.b So far we moved unused ieee1394 EXPORTs into #if/#endif blocks
and let people reactivate them via kernel config.
2. If it will be decided to remove or hide the EXPORTs and implementations, then the following should go as well:
2.a EXPORT and implementation of hpsb_unlisten_channel() 2.b struct member hpsb_host.iso_listen_count[]
3. These should go regardless of the EXPORTs matter:
struct members file_info.listen_channels, file_info.iso_buffer, file_info.iso_buffer_length.
Perhaps there is even *much* more code which becomes superfluous which I am unable to identify now.
Signature · 3 lines
Stefan Richter -=====-=-==- -=-- -=--- http://arcgraph.de/sr/
Quoted 10 lines · Stefan Richter
Quoted 2 lines · Adrian Bunk
This patch contains the overdue removal of the
RAW1394_REQ_ISO_SENDandRAW1394_REQ_ISO_LISTENrequest types plus all support code for them.[...]
I am not familiar with the isochronous part of Linux' 1394 software stack, so I can't comment whether there are high-profile applications which still did not migrate away from this interface, or did so only recently.
Kino still uses the legacy raw1394 iso interface for capture by default; however, it can also still use dv1394. I will accellerate the adoption of the new raw1394 interface since I have already done this for dvgrab 2.0. Cinelerra supports libiec61883 now.
Unfortunately, gstreamer still uses legacy raw1394 iso interface, but I can nag someone at Fluendo. I think another high profile app that might be affected is GnomeMeeting/Ekiga, but I have not kept close track of it.
Also, I have not released a version of libraw1394 that contains the deprecation warnings, but I can do so this weekend. And then another release when the removed kernel interfaces are released that removes the functions.
Quoted 5 lines · Dan Dennedy
Kino still uses the legacy raw1394 iso interface for capture by default; however, it can also still use dv1394. I will accellerate the adoption of the new raw1394 interface since I have already done this for dvgrab 2.0. Cinelerra supports libiec61883 now.
Unfortunately, gstreamer still uses legacy raw1394 iso interface, but I can nag someone at Fluendo. I think another high profile app that might be affected is GnomeMeeting/Ekiga, but I have not kept close track of it.
Also, I have not released a version of libraw1394 that contains the deprecation warnings, but I can do so this weekend. And then another release when the removed kernel interfaces are released that removes the functions.
Then I suggest we adjust the date in Documentation/feature-removal-schedule.txt (increment by 1 year?) and also list kino and gstreamer as affected application programs there.
It appears from grep'ing through the sources of Ekiga 2.0.1 that it does not access (lib)raw1394 by itself.
Signature · 3 lines
Stefan Richter -=====-=-==- -=-- -=--- http://arcgraph.de/sr/
Quoted 2 lines
Quoted 1 line · Dan Dennedy
Also, I have not released a version of libraw1394 that contains the deprecation warnings, but I can do so this weekend. And then another release when the removed kernel interfaces are released that removes the functions.
We should have added such warnings already to the kernel at the moment when the two ioctls went into feature-removal-schedule.txt.
Signature · 3 lines
Stefan Richter -=====-=-==- -=-- -=--- http://arcgraph.de/sr/
Quoted 2 lines · Stefan Richter
We should have added such warnings already to the kernel at the moment when the two ioctls went into feature-removal-schedule.txt.
We originally decided just to put it into libraw1394. I don't see the point of having it in two places, but I suppose it couldn't hurt.. I'll take a patch :)
Cheers,
Jody
Quoted 4 lines
Signature · 3 lines
Stefan Richter -=====-=-==- -=-- -=--- http://arcgraph.de/sr/
Quoted 7 lines · Jody McIntyre
Quoted 2 lines · Stefan Richter
We should have added such warnings already to the kernel at the moment when the two ioctls went into feature-removal-schedule.txt.
We originally decided just to put it into libraw1394. I don't see the point of having it in two places, but I suppose it couldn't hurt.. I'll take a patch :)
The compile warnings were put into libraw1394 repo a while ago, but there was not a release containing them until about a week ago.
Signature · 1 line
+-DRD-+
Quoted 6 lines · Stefan Richter
Quoted 3 lines · Dan Dennedy
can nag someone at Fluendo. I think another high profile app that might be affected is GnomeMeeting/Ekiga, but I have not kept close track of it.
It appears from grep'ing through the sources of Ekiga 2.0.1 that it does not access (lib)raw1394 by itself.
I just checked, and it is actually in the openh323 pwlib's vidinput_avc module.
Quoted 4 lines · Stefan Richter
Then I suggest we adjust the date in
Documentation/feature-removal-schedule.txt(increment by 1 year?) and also list kino and gstreamer as affected application programs there.
Done.
Cheers,
Jody
Quoted 17 lines
It appears from grep'ing through the sources of Ekiga 2.0.1 that it does not access (lib)raw1394 by itself.
Signature · 13 lines
Stefan Richter -=====-=-==- -=-- -=--- http://arcgraph.de/sr/ ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux1394-devel