patman: use new --u-boot option with checkpath.pl
PATCH 1/1 patman: use new --u-boot option with checkpath.pl
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series.
---
tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/patman/checkpatch.py +1 -1
@@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): result.problems = [] chk = FindCheckPatch() item = {} - result.stdout = command.Output(chk, '--no-tree', fname, + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, raise_on_error=False) #pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) #stdout, stderr = pipe.communicate()
Signature · 1 line
2.27.0
PATCH 1/1 patman: use new --u-boot option with checkpath.pl
Hi Daniel,
Quoted 16 lines · Daniel Schwierzeck
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series.
Signed-off-by Daniel Schwierzeck <[email protected]>---
tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/patman/checkpatch.py +0
-0
tools/patman/checkpatch.py def CheckPatch(fname, verbose=False): · line 68
Quoted 6 lines
tools/patman/checkpatch.py +1
-1@@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): result.problems = [] chk = FindCheckPatch() item = {} - result.stdout = command.Output(chk, '--no-tree', fname, + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, raise_on_error=False)
Can we make this conditional on something? Maybe detecting a U-Boot tree? Patman is used for linux and Zephyr, for example.
Quoted 5 lines
tools/patman/checkpatch.py +0
-1#pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) #stdout, stderr = pipe.communicate() --2.27.0
Regards,
Simon
PATCH 1/1 patman: use new --u-boot option with checkpath.pl
Hi Daniel,
Quoted 16 lines · Simon Glass
Hi Daniel,
Quoted 11 lines · Daniel Schwierzeck
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series.
Signed-off-by Daniel Schwierzeck <[email protected]>---
tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
tools/patman/checkpatch.py def CheckPatch(fname, verbose=False): · line 68
Quoted 11 lines
tools/patman/checkpatch.py +1
-1@@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): result.problems = [] chk = FindCheckPatch() item = {} - result.stdout = command.Output(chk, '--no-tree', fname, + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, raise_on_error=False)Can we make this conditional on something? Maybe detecting a U-Boot tree? Patman is used for linux and Zephyr, for example.
Actually I just remembered that I was hoping we could just adjust the .checkpatch.conf file in the U-Boot directory to add the option. Would that work?
Quoted 6 lines
Quoted 6 lines
tools/patman/checkpatch.py +0
-1#pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) #stdout, stderr = pipe.communicate() --2.27.0
Regards,
Simon
PATCH 1/1 patman: use new --u-boot option with checkpath.pl
Am 07.06.20 um 05:44 schrieb Simon Glass:
Quoted 34 lines
Hi Daniel,
Quoted 16 lines · Simon Glass
Hi Daniel,
Quoted 11 lines · Daniel Schwierzeck
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series.
Signed-off-by Daniel Schwierzeck <[email protected]>---
tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 14 lines
tools/patman/checkpatch.py def CheckPatch(fname, verbose=False): · line 68
Quoted 11 lines
tools/patman/checkpatch.py +1
-1@@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): result.problems = [] chk = FindCheckPatch() item = {} - result.stdout = command.Output(chk, '--no-tree', fname, + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, raise_on_error=False)Can we make this conditional on something? Maybe detecting a U-Boot tree? Patman is used for linux and Zephyr, for example.
Quoted 4 lines
Actually I just remembered that I was hoping we could just adjust the .checkpatch.conf file in the U-Boot directory to add the option. Would that work?
hm, missed that earlier but you already added that with commit b77df5980c3e24e34e0db3a52c5bce396a81c430. Then you can ignore this patch ;)
Signature · 1 line
- Daniel
PATCH 1/1 patman: use new --u-boot option with checkpath.pl
Hi Daniel,
Quoted 38 lines · Daniel Schwierzeck
Am 07.06.20 um 05:44 schrieb Simon Glass:
Quoted 34 lines
Hi Daniel,
Quoted 30 lines · Simon Glass
Hi Daniel,
Quoted 16 lines · Daniel Schwierzeck
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series.
Signed-off-by Daniel Schwierzeck <[email protected]>---
tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/patman/checkpatch.py +0
-0tools/patman/checkpatch.py def CheckPatch(fname, verbose=False): · line 68
Quoted 6 lines
tools/patman/checkpatch.py +1
-1@@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): result.problems = [] chk = FindCheckPatch() item = {} - result.stdout = command.Output(chk, '--no-tree', fname, + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, raise_on_error=False)Can we make this conditional on something? Maybe detecting a U-Boot tree? Patman is used for linux and Zephyr, for example.
Quoted 7 lines
Quoted 4 lines
Actually I just remembered that I was hoping we could just adjust the .checkpatch.conf file in the U-Boot directory to add the option. Would that work?
hm, missed that earlier but you already added that with commit
b77df5980c3e24e34e0db3a52c5bce396a81c430. Then you can ignore this patch ;)
Ah OK. Does it work correctly for you?
Regards,
Simon