Skip to contentSkip to conversation

arm64: dts: rockchip: add EEPROM node for NanoPi R4S

PATCH Superseded Tianling Shen 2 participants 3 messages Jun 10, 2021 – Jun 20, 2021

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: add EEPROM node for NanoPi R4S

NanoPi R4S has a EEPROM attached to the 2nd I2C bus (U92), which stores the MAC address.

Changes in v2:
- Added the size of EEPROM
- Added mac-address cell to pass the MAC address to kernel
- Removed read-only property in EEPROM node

---
 .../boot/dts/rockchip/rk3399-nanopi-r4s.dts    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts +18 -0
index cef4d18b599d..50d3b11eb925 100644
@@ -68,6 +68,24 @@
 	status = "disabled";
 };
 
+&gmac {
+	nvmem-cells = <&mac_address>;
+	nvmem-cells-names = "mac-address";
+};
+
+&i2c2 {
+	eeprom@51 {
+		compatible = "microchip,24c02", "atmel,24c02";
+		reg = <0x51>;
+		pagesize = <16>;
+		size = <256>;
+
+		mac_address: mac-address@fa {
+			reg = <0xfa 0x06>;
+		};
+	};
+};
+
 &i2c4 {
 	status = "disabled";
 };
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Hi,

Am Donnerstag, 10. Juni 2021, 11:13:57 CEST schrieb Tianling Shen:

Quoted 9 lines

NanoPi R4S has a EEPROM attached to the 2nd I2C bus (U92), which stores the MAC address.

Changes in v2:
- Added the size of EEPROM
- Added mac-address cell to pass the MAC address to kernel
- Removed read-only property in EEPROM node

this produces errors when building the dtb:
DTC arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dtb
../arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts:84.4-22: Warning (reg_format): /i2c@ff120000/eeprom@51/mac-address@fa:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' ../arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts:83.31-85.5: Warning (avoid_default_addr_size): /i2c@ff120000/eeprom@51/mac-address@fa: Relying on default #address-cells value ../arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts:83.31-85.5: Warning (avoid_default_addr_size): /i2c@ff120000/eeprom@51/mac-address@fa: Relying on default #size-cells value

in the eeprom node you'll need to define #address-cells and #size-cells for this to work.

Thanks
Heiko

Quoted 34 lines
---
 .../boot/dts/rockchip/rk3399-nanopi-r4s.dts    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts +18 -0
index cef4d18b599d..50d3b11eb925 100644
@@ -68,6 +68,24 @@
 	status = "disabled";
 };
 
+&gmac {
+	nvmem-cells = <&mac_address>;
+	nvmem-cells-names = "mac-address";
+};
+
+&i2c2 {
+	eeprom@51 {
+		compatible = "microchip,24c02", "atmel,24c02";
+		reg = <0x51>;
+		pagesize = <16>;
+		size = <256>;
+
+		mac_address: mac-address@fa {
+			reg = <0xfa 0x06>;
+		};
+	};
+};
+
 &i2c4 {
 	status = "disabled";
 };
#2 lore raw

Hi Heiko,

Quoted 23 lines · Heiko Stuebner

Hi,

Am Donnerstag, 10. Juni 2021, 11:13:57 CEST schrieb Tianling Shen:

Quoted 9 lines

NanoPi R4S has a EEPROM attached to the 2nd I2C bus (U92), which stores the MAC address.

Changes in v2:
- Added the size of EEPROM
- Added mac-address cell to pass the MAC address to kernel
- Removed read-only property in EEPROM node

this produces errors when building the dtb:
DTC arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dtb
../arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts:84.4-22: Warning (reg_format): /i2c@ff120000/eeprom@51/mac-address@fa:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' ../arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts:83.31-85.5: Warning (avoid_default_addr_size): /i2c@ff120000/eeprom@51/mac-address@fa: Relying on default #address-cells value ../arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts:83.31-85.5: Warning (avoid_default_addr_size): /i2c@ff120000/eeprom@51/mac-address@fa: Relying on default #size-cells value

Quoted 2 lines

in the eeprom node you'll need to define #address-cells and #size-cells for this to work.

Thanks for pointing this out, added in v3.

Thanks,
Tianling.

Quoted 43 lines

Thanks
Heiko

Quoted 34 lines
---
 .../boot/dts/rockchip/rk3399-nanopi-r4s.dts    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts +18 -0
index cef4d18b599d..50d3b11eb925 100644
@@ -68,6 +68,24 @@
      status = "disabled";
 };
 
+&gmac {
+     nvmem-cells = <&mac_address>;
+     nvmem-cells-names = "mac-address";
+};
+
+&i2c2 {
+     eeprom@51 {
+             compatible = "microchip,24c02", "atmel,24c02";
+             reg = <0x51>;
+             pagesize = <16>;
+             size = <256>;
+
+             mac_address: mac-address@fa {
+                     reg = <0xfa 0x06>;
+             };
+     };
+};
+
 &i2c4 {
      status = "disabled";
 };