Skip to contentSkip to conversation

Documentation/wmi: Fix Typo in lenovo-wmi-gamezone

PATCH In review rakuram 4 participants 5 messages Aug 17, 2025 – Sep 15, 2025

Subsystems (4)
lore
Share & tools
lore

rakuram

author
#0 lore raw

PATCH 1/1 Documentation/wmi: Fix Typo in lenovo-wmi-gamezone

Fixed the below typo error

freqency ==> frequency
in Documentation/wmi/devices/lenovo-wmi-gamezone.rst

---
 Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +1 -1
index 997263e51a7d..22040250a97d 100644
@@ -153,7 +153,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
     [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID;
     [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID;
     [WmiDataId(3), read, Description("Default value.")] uint32 defaultvalue;
-    [WmiDataId(4), read, Description("OC Offset freqency.")] uint32 OCOffsetFreq;
+    [WmiDataId(4), read, Description("OC Offset frequency.")] uint32 OCOffsetFreq;
     [WmiDataId(5), read, Description("OC Min offset value.")] uint32 OCMinOffset;
     [WmiDataId(6), read, Description("OC Max offset value.")] uint32 OCMaxOffset;
     [WmiDataId(7), read, Description("OC Offset Scale.")] uint32 OCOffsetScale;
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · rakuram

Fixed the below typo error

freqency ==> frequency
in Documentation/wmi/devices/lenovo-wmi-gamezone.rst

---
 Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0 -0
index 997263e51a7d..22040250a97d 100644
@@ -153,7 +153,7 @@ data using the `bmfdec 

<https://github.com/pali/bmfdec>`_ utility:

     [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID;
     [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID;
     [WmiDataId(3), read, Description("Default value.")] uint32 
Quoted 13 lines

defaultvalue;
- [WmiDataId(4), read, Description("OC Offset freqency.")] uint32
OCOffsetFreq;
+ [WmiDataId(4), read, Description("OC Offset frequency.")] uint32
OCOffsetFreq;
[WmiDataId(5), read, Description("OC Min offset value.")] uint32
OCMinOffset;
[WmiDataId(6), read, Description("OC Max offset value.")] uint32
OCMaxOffset;
[WmiDataId(7), read, Description("OC Offset Scale.")] uint32
OCOffsetScale;

Signature · 1 line
2.43.0

Looks good to me.

Mark

maintainer
#2 lore raw
Quoted 36 lines · Mark Pearson
Quoted 20 lines · rakuram

Fixed the below typo error

freqency ==> frequency
in Documentation/wmi/devices/lenovo-wmi-gamezone.rst

---
 Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0 -0
index 997263e51a7d..22040250a97d 100644
@@ -153,7 +153,7 @@ data using the `bmfdec 

<https://github.com/pali/bmfdec>`_ utility:

     [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID;
     [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID;
     [WmiDataId(3), read, Description("Default value.")] uint32 
Quoted 13 lines

defaultvalue;
- [WmiDataId(4), read, Description("OC Offset freqency.")] uint32
OCOffsetFreq;
+ [WmiDataId(4), read, Description("OC Offset frequency.")] uint32
OCOffsetFreq;
[WmiDataId(5), read, Description("OC Min offset value.")] uint32
OCMinOffset;
[WmiDataId(6), read, Description("OC Max offset value.")] uint32
OCMaxOffset;
[WmiDataId(7), read, Description("OC Offset Scale.")] uint32
OCOffsetScale;

Signature · 1 line
2.43.0

Looks good to me.

Quoted 1 line

Hi,

Isn't the typo in the original interface as well? I'm not very keen in accepting this kind of patches as this part is not really user documentation to begin with.

Signature · 1 line
 i.
maintainer
#3 lore raw

Hi Ilpo,

Quoted 39 lines · Ilpo Järvinen
Quoted 36 lines · Mark Pearson
Quoted 20 lines · rakuram

Fixed the below typo error

freqency ==> frequency
in Documentation/wmi/devices/lenovo-wmi-gamezone.rst

---
 Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0 -0
index 997263e51a7d..22040250a97d 100644
@@ -153,7 +153,7 @@ data using the `bmfdec 

<https://github.com/pali/bmfdec>`_ utility:

     [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID;
     [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID;
     [WmiDataId(3), read, Description("Default value.")] uint32 
Quoted 13 lines

defaultvalue;
- [WmiDataId(4), read, Description("OC Offset freqency.")] uint32
OCOffsetFreq;
+ [WmiDataId(4), read, Description("OC Offset frequency.")] uint32
OCOffsetFreq;
[WmiDataId(5), read, Description("OC Min offset value.")] uint32
OCMinOffset;
[WmiDataId(6), read, Description("OC Max offset value.")] uint32
OCMaxOffset;
[WmiDataId(7), read, Description("OC Offset Scale.")] uint32
OCOffsetScale;

Signature · 1 line
2.43.0

Looks good to me.

Quoted 1 line
Quoted 6 lines

Hi,

Isn't the typo in the original interface as well? I'm not very keen in accepting this kind of patches as this part is not really user documentation to begin with.

I haven't had a chance to double check - but it's kinda bad that we had that typo in the original implementation to be honest. I can ask to get that fixed, but it will likely take a long time for something minor. I defer to you on the preference for kernel documentation - I suspect we'll get a bunch of these though (part of the 'getting started to contributing to the kernel' is always typos and documentation right?).

Mark

maintainer
#4 lore raw

Am 15.09.25 um 20:23 schrieb Mark Pearson:

Quoted 42 lines

Hi Ilpo,

Quoted 39 lines · Ilpo Järvinen
Quoted 35 lines · Mark Pearson
Quoted 20 lines · rakuram

Fixed the below typo error

freqency ==> frequency
in Documentation/wmi/devices/lenovo-wmi-gamezone.rst

---
  Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0 -0
index 997263e51a7d..22040250a97d 100644
@@ -153,7 +153,7 @@ data using the `bmfdec

<https://github.com/pali/bmfdec>`_ utility:

      [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID;
      [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID;
      [WmiDataId(3), read, Description("Default value.")] uint32
Quoted 13 lines

defaultvalue;
- [WmiDataId(4), read, Description("OC Offset freqency.")] uint32
OCOffsetFreq;
+ [WmiDataId(4), read, Description("OC Offset frequency.")] uint32
OCOffsetFreq;
[WmiDataId(5), read, Description("OC Min offset value.")] uint32
OCMinOffset;
[WmiDataId(6), read, Description("OC Max offset value.")] uint32
OCMaxOffset;
[WmiDataId(7), read, Description("OC Offset Scale.")] uint32
OCOffsetScale;

Signature · 1 line
2.43.0

Looks good to me.

Quoted 1 line

Hi,

Quoted 8 lines
Quoted 4 lines

Isn't the typo in the original interface as well? I'm not very keen in accepting this kind of patches as this part is not really user documentation to begin with.

I haven't had a chance to double check - but it's kinda bad that we had that typo in the original implementation to be honest. I can ask to get that fixed, but it will likely take a long time for something minor. I defer to you on the preference for kernel documentation - I suspect we'll get a bunch of these though (part of the 'getting started to contributing to the kernel' is always typos and documentation right?).

Mark

I agree, the typo is inside the WMI MOF definition which is included inside the documentation for future developers. Since this MOF definition should match the actual MOF definition reported by the ACPI firmware, i suggest that we ignore any spelling mistakes inside those.

Thanks,
Armin Wolf