ehca: integration in Linux kernel build system
PATCH 1/16 ehca: integration in Linux kernel build system
Kconfig | 6 ++++++ Makefile | 29 +++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+)
drivers/infiniband/hw/ehca/Kconfig +6 -0
@@ -0,0 +1,6 @@ +config INFINIBAND_EHCA + tristate "eHCA support" + depends on IBMEBUS && INFINIBAND + ---help--- + This is a low level device driver for the IBM + GX based Host channel adapters (HCAs)
drivers/infiniband/hw/ehca/Makefile +29 -0
@@ -0,0 +1,29 @@ +# Authors: Heiko J Schick <[email protected]> +# Christoph Raisch <[email protected]> +# +# Copyright (c) 2005 IBM Corporation +# +# All rights reserved. +# +# This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD. + +obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o + +hcad_mod-objs = ehca_main.o \ + ehca_hca.o \ + ehca_mcast.o \ + ehca_pd.o \ + ehca_av.o \ + ehca_eq.o \ + ehca_cq.o \ + ehca_qp.o \ + ehca_sqp.o \ + ehca_mrmw.o \ + ehca_reqs.o \ + ehca_irq.o \ + ehca_uverbs.o \ + hcp_if.o \ + hcp_phyp.o \ + ipz_pt_fn.o + +CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL
Quoted 2 lines · Heiko J Schick
Signed-off-by Heiko J Schick <[email protected]>
Missing any description whatsoever.
Quoted 5 lines
Kconfig| 6 ++++++
Makefile| 29 +++++++++++++++++++++++++++++2 files changed, 35 insertions(+)
It would be more practical to put this patch last instead of first so you don't break the build system with partial applies.
Quoted 33 lines
drivers/infiniband/hw/ehca/Kconfig 2006-01-04 16:29:05.000000000 +0100 renamed from drivers/infiniband/hw/ehca/Kconfig 1970-01-01 01:00:00.000000000 +0100 +6
-0@@ -0,0 +1,6 @@ +config INFINIBAND_EHCA + tristate "eHCA support" + depends on IBMEBUS && INFINIBAND + ---help--- + This is a low level device driver for the IBM + GX based Host channel adapters (HCAs)drivers/infiniband/hw/ehca/Makefile 2006-03-06 12:26:36.000000000 +0100 renamed from drivers/infiniband/hw/ehca/Makefile 1970-01-01 01:00:00.000000000 +0100 +19
-0@@ -0,0 +1,29 @@ +# Authors: Heiko J Schick <[email protected]> +# Christoph Raisch <[email protected]> +# +# Copyright (c) 2005 IBM Corporation +# +# All rights reserved. +# +# This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD. + +obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o + +hcad_mod-objs = ehca_main.o \ + ehca_hca.o \ + ehca_mcast.o \ + ehca_pd.o \ + ehca_av.o \ + ehca_eq.o \ + ehca_cq.o \ + ehca_qp.o \
drivers/infiniband/hw/ehca/Makefile 2006-03-06 12:26:36.000000000 +0100 line 29
Quoted 10 lines
drivers/infiniband/hw/ehca/Makefile 2006-03-06 12:26:36.000000000 +0100 renamed from drivers/infiniband/hw/ehca/Makefile 1970-01-01 01:00:00.000000000 +0100 +10
-0+ ehca_sqp.o \ + ehca_mrmw.o \ + ehca_reqs.o \ + ehca_irq.o \ + ehca_uverbs.o \ + hcp_if.o \ + hcp_phyp.o \ + ipz_pt_fn.o + +CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL
Do these need to be on the command line? If you always set them anyways, you can probably get rid of the #ifdef checking for them. If you want to keep the code for some reason, it might be better to have a CONFIG_EHCA_USE_HCALL symbol that is set unconditionally from Kconfig.
Arnd <><
Quoted 2 lines · Arnd Bergmann
It would be more practical to put this patch last instead of first so you don't break the build system with partial applies.
I agree. I Will change set for the next patchset.
Quoted 7 lines · Heiko J Schick
drivers/infiniband/hw/ehca/Makefile +7
-0+ +hcad_mod-objs = ehca_main.o \ + ehca_hca.o \ + ehca_mcast.o \ + ehca_pd.o \ + ehca_av.o \ + ehca_eq.o \
drivers/infiniband/hw/ehca/Makefile line 27
Quoted 10 lines
drivers/infiniband/hw/ehca/Makefile +10
-0+ ehca_cq.o \ + ehca_qp.o \ + ehca_sqp.o \ + ehca_mrmw.o \ + ehca_reqs.o \ + ehca_irq.o \ + ehca_uverbs.o \ + hcp_if.o \ + hcp_phyp.o \ + ipz_pt_fn.o
If you don't consolidate this into 2-3 lines, Sam might turn you into a toad.
Jörn
Signature · 2 lines
Audacity augments courage; hesitation, fear. -- Publilius Syrus