Skip to contentSkip to conversation

DECnet: Fix level1 router hello

PATCH Applied Patrick Caulfield 2 participants 2 messages Apr 27, 2006 – May 4, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DECnet: Fix level1 router hello

This patch fixes hello messages sent when a node is a level 1 router. Slightly contrary to the spec (maybe) VMS ignores hello messages that do not name level2 routers that it also knows about.

So, here we simply name all the routers that the node knows about rather just other level1 routers.
(I hope the patch is clearer than the description. sorry).

Patrick

net/decnet/dn_neigh.c +0 -5
index 7c8692c..66e230c 100644
@@ -493,7 +493,6 @@ struct elist_cb_state {
 static void neigh_elist_cb(struct neighbour *neigh, void *_info)
 {
 	struct elist_cb_state *s = _info;
-	struct dn_dev *dn_db;
 	struct dn_neigh *dn;
 
 	if (neigh->dev != s->dev)
@@ -503,10 +502,6 @@ static void neigh_elist_cb(struct neighb
 	if (!(dn->flags & (DN_NDFLAG_R1|DN_NDFLAG_R2)))
 		return;
 
-	dn_db = (struct dn_dev *) s->dev->dn_ptr;
-	if (dn_db->parms.forwarding == 1 && (dn->flags & DN_NDFLAG_R2))
-		return;
-
 	if (s->t == s->n)
 		s->rs = dn_find_slot(s->ptr, s->n, dn->priority);
 	else
maintainer Applied
#1 lore raw

From: Patrick Caulfield <[email protected]>
Date: Thu, 27 Apr 2006 13:37:23 +0100

Quoted 11 lines

This patch fixes hello messages sent when a node is a level 1 router. Slightly contrary to the spec (maybe) VMS ignores hello messages that do not name level2 routers that it also knows about.

So, here we simply name all the routers that the node knows about rather just other level1 routers.
(I hope the patch is clearer than the description. sorry).

Patrick

Applied, thanks Patrick.