blank lines at EOF fixes
cover blank lines at EOF fixes
Using a simple shell script which cleans up trailing whitespace found several places with extra lines at end of file.
More in base drivers but they are known to be problematic.
Stephen Hemminger (5):
examples: remove extra blank lines at eof
test: remove blank lines at eof
pmdinfogen: remove blank line at eof
net/ipn3ke: cleanup blank line at eof
net/mlx5: remove blank lines at eof
app/test/test_cryptodev_asym_util.h | 4 ---- app/test/test_table_combined.c | 1 - app/test/test_table_tables.c | 3 +-- buildtools/pmdinfogen/pmdinfogen.h | 1 - drivers/net/ipn3ke/ipn3ke_flow.c | 1 - drivers/net/ipn3ke/ipn3ke_tm.c | 1 - drivers/net/mlx5/mlx5_rxtx.c | 2 -- examples/flow_filtering/flow_blocks.c | 1 - examples/l3fwd-power/perf_core.c | 1 - examples/vhost_scsi/vhost_scsi.c | 1 - 10 files changed, 1 insertion(+), 15 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/5 examples: remove extra blank lines at eof
There should not be blank lines at end of files.
--- examples/flow_filtering/flow_blocks.c | 1 - examples/l3fwd-power/perf_core.c | 1 - examples/vhost_scsi/vhost_scsi.c | 1 - 3 files changed, 3 deletions(-)
examples/flow_filtering/flow_blocks.c +0 -1
@@ -98,4 +98,3 @@ generate_ipv4_flow(uint16_t port_id, uint16_t rx_q,return flow; } -
examples/l3fwd-power/perf_core.c +0 -1
@@ -227,4 +227,3 @@ parse_perf_core_list(const char *corelist)return 0 ; } -
examples/vhost_scsi/vhost_scsi.c +0 -1
@@ -485,4 +485,3 @@ int main(int argc, char *argv[])return 0 ; } -
Signature · 1 line
2.20.1
PATCH 2/5 test: remove blank lines at eof
In reply to Stephen HemmingerSeveral tests have extraneous blank lines at end of file.
--- app/test/test_cryptodev_asym_util.h | 4 ---- app/test/test_table_combined.c | 1 - app/test/test_table_tables.c | 3 +-- 3 files changed, 1 insertion(+), 7 deletions(-)
app/test/test_cryptodev_asym_util.h +0 -4
@@ -36,7 +36,3 @@ static inline int verify_modexp(uint8_t *mod_exp, }#endif /* TEST_CRYPTODEV_ASYM_TEST_UTIL_H__ */ - - - -
app/test/test_table_combined.c +0 -1
@@ -840,4 +840,3 @@ test_table_hash_cuckoo_combined(void)return 0 ; } -
app/test/test_table_tables.c +1 -2
@@ -911,7 +911,7 @@ test_table_hash_cuckoo(void) .n_keys = 1 << 16, .n_buckets = 1 << 16, .f_hash = pipeline_test_hash_cuckoo, - .seed = 0, + .seed = 0, }; table = rte_table_hash_cuckoo_ops.f_create (NULL ,0 , entry_size);
@@ -1051,4 +1051,3 @@ test_table_hash_cuckoo(void)return 0 ; } -
Signature · 1 line
2.20.1
PATCH 3/5 pmdinfogen: remove blank line at eof
In reply to Stephen HemmingerNo need for blank line at end of file.
--- buildtools/pmdinfogen/pmdinfogen.h | 1 - 1 file changed, 1 deletion(-)
buildtools/pmdinfogen/pmdinfogen.h +0 -1
@@ -122,4 +122,3 @@ struct elf_info {struct pmd_driver *drivers; }; -
Signature · 1 line
2.20.1
PATCH 4/5 net/ipn3ke: cleanup blank line at eof
In reply to Stephen HemmingerLeftover from editor? Remove blank lines at end of file.
--- drivers/net/ipn3ke/ipn3ke_flow.c | 1 - drivers/net/ipn3ke/ipn3ke_tm.c | 1 - 2 files changed, 2 deletions(-)
drivers/net/ipn3ke/ipn3ke_flow.c +0 -1
@@ -1372,4 +1372,3 @@ const struct rte_flow_ops ipn3ke_flow_ops = { .destroy = ipn3ke_flow_destroy, .flush = ipn3ke_flow_flush, }; -
drivers/net/ipn3ke/ipn3ke_tm.c +0 -1
@@ -2060,4 +2060,3 @@ ipn3ke_tm_ops_get(struct rte_eth_dev *ethdev,return 0 ; } -
Signature · 1 line
2.20.1
PATCH 5/5 net/mlx5: remove blank lines at eof
In reply to Stephen HemmingerWhitespace fix.
--- drivers/net/mlx5/mlx5_rxtx.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/mlx5/mlx5_rxtx.c +0 -2
@@ -5161,5 +5161,3 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)DRV_LOG (DEBUG ,"\tEMPW (Enhanced MPW)" );return txoff_func[m].func; } - -
Signature · 1 line
2.20.1
Re: [dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eof
Quoted 10 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Wednesday, July 31, 2019 17:58
To: [email protected]
Cc: Stephen Hemminger <[email protected]>
Subject: [dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eofWhitespace fix.
Signed-off-by Stephen Hemminger <[email protected]>
Thank you,
Slava
Quoted 16 lines
--- drivers/net/mlx5/mlx5_rxtx.c | 2 -- 1 file changed, 2 deletions(-)drivers/net/mlx5/mlx5_rxtx.c +0
-3@@ -5161,5 +5161,3 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)DRV_LOG (DEBUG ,"\tEMPW (Enhanced MPW)" );return txoff_func[m].func; } - - --2.20.1
Quoted 12 lines · Stephen Hemminger
Using a simple shell script which cleans up trailing whitespace found several places with extra lines at end of file.
More in base drivers but they are known to be problematic.
Stephen Hemminger (5):
examples: remove extra blank lines at eof
test: remove blank lines at eof
pmdinfogen: remove blank line at eof
net/ipn3ke: cleanup blank line at eof
net/mlx5: remove blank lines at eof
Quoted 12 lines
app/test/test_cryptodev_asym_util.h | 4 ---- app/test/test_table_combined.c | 1 - app/test/test_table_tables.c | 3 +-- buildtools/pmdinfogen/pmdinfogen.h | 1 - drivers/net/ipn3ke/ipn3ke_flow.c | 1 - drivers/net/ipn3ke/ipn3ke_tm.c | 1 - drivers/net/mlx5/mlx5_rxtx.c | 2 -- examples/flow_filtering/flow_blocks.c | 1 - examples/l3fwd-power/perf_core.c | 1 - examples/vhost_scsi/vhost_scsi.c | 1 - 10 files changed, 1 insertion(+), 15 deletions(-)
I really wonder if removing blank lines at EOF would really be a problem for base drivers? Seems like it should not be a major issue, but perhaps maintainers best comment first.
31/07/2019 17:38, Bruce Richardson:
Quoted 25 lines · Stephen Hemminger
Quoted 12 lines
Using a simple shell script which cleans up trailing whitespace found several places with extra lines at end of file.
More in base drivers but they are known to be problematic.
Stephen Hemminger (5):
examples: remove extra blank lines at eof
test: remove blank lines at eof
pmdinfogen: remove blank line at eof
net/ipn3ke: cleanup blank line at eof
net/mlx5: remove blank lines at eofQuoted 12 lines
app/test/test_cryptodev_asym_util.h | 4 ---- app/test/test_table_combined.c | 1 - app/test/test_table_tables.c | 3 +-- buildtools/pmdinfogen/pmdinfogen.h | 1 - drivers/net/ipn3ke/ipn3ke_flow.c | 1 - drivers/net/ipn3ke/ipn3ke_tm.c | 1 - drivers/net/mlx5/mlx5_rxtx.c | 2 -- examples/flow_filtering/flow_blocks.c | 1 - examples/l3fwd-power/perf_core.c | 1 - examples/vhost_scsi/vhost_scsi.c | 1 - 10 files changed, 1 insertion(+), 15 deletions(-)
Quoted 1 line
Series-acked-by Bruce Richardson <[email protected]>
Applied and squashed, thanks