ftdi_sio: ACT Solutions HomePro ZWave interface
Subsystems (2)
PATCH 1/1 ftdi_sio: ACT Solutions HomePro ZWave interface
drivers/usb/serial/ftdi_sio.c +1 -0
@@ -307,6 +307,7 @@static struct usb_device_id id_table_combined [] = { + {USB_DEVICE (FTDI_VID ,FTDI_ACTZWAVE_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_IRTRANS_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_SIO_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_8U232AM_PID ) },
drivers/usb/serial/ftdi_sio.h +3 -0
@@ -380,6 +380,9 @@/* Pyramid Computer GmbH */ #define FTDI_PYRAMID_PID 0xE6C8/* Pyramid Appliance Display */ +/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */ +#define FTDI_ACTZWAVE_PID 0xF2D0 +/* * Posiflex inc retail equipment (http://www.posiflex.com.tw) */
On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have been added there.
You also forgot to add a "Signed-off-by:" line :(
Quoted 15 lines
diff -Nur
linux-2.6.16.12/drivers/usb/serial/ftdi_sio.clinux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.cdrivers/usb/serial/ftdi_sio.c +1
-0@@ -307,6 +307,7 @@static struct usb_device_id id_table_combined [] = { + {USB_DEVICE (FTDI_VID ,FTDI_ACTZWAVE_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_IRTRANS_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_SIO_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_8U232AM_PID ) },diff -Nur
linux-2.6.16.12/drivers/usb/serial/ftdi_sio.hlinux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h
drivers/usb/serial/ftdi_sio.h line 384
Quoted 5 lines
drivers/usb/serial/ftdi_sio.h +2
-0@@ -380,6 +380,9 @@/* Pyramid Computer GmbH */ #define FTDI_PYRAMID_PID 0xE6C8/* Pyramid Appliance Display */ +/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */ +#define FTDI_ACTZWAVE_PID 0xF2D0
Please use a tab here.
thanks,
greg k-h
Quoted 6 lines · Greg KH
On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have been added there.
You also forgot to add a "Signed-off-by:" line :(
Signed-Off By: Razvan Gavril <[email protected]>
---
drivers/usb/serial/ftdi_sio.c 2006-05-03 15:04:39.000000000 +0300 renamed from drivers/usb/serial/ftdi_sio.c 2006-05-03 15:12:01.000000000 +0300 +0 -0
@@ -307,6 +307,7 @@
static struct usb_device_id id_table_combined [] = {
+ { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },drivers/usb/serial/ftdi_sio.h 2006-05-03 15:13:26.000000000 +0300 renamed from drivers/usb/serial/ftdi_sio.h 2006-05-03 15:09:33.000000000 +0300 +0 -0
@@ -32,6 +32,10 @@
#define FTDI_NF_RIC_PID 0x0001 /* Product Id */
+/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */
+#define FTDI_ACTZWAVE_PID 0xF2D0
+
+
/* www.irtrans.de device */
#define FTDI_IRTRANS_PID 0xFC60 /* Product Id */
Quoted 9 lines · Razvan Gavril
Quoted 6 lines · Greg KH
On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have been added there.
You also forgot to add a "Signed-off-by:" line :(
Signed-Off By: Razvan Gavril <[email protected]>
Care to add a good text for what the patch does?
Quoted 6 lines
---
diff -Nur
linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.clinux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c
---linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c2006-05-03 15:12:01.000000000 +0300
The patch is line wrapped :(
Review line 313
Quoted 10 lines
+++
linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c2006-05-03
15:04:39.000000000 +0300(quoted diff) +1
-0@@ -307,6 +307,7 @@ static struct usb_device_id id_table_combined [] = { + { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) }, { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) }, { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) }, { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
And the tabs were stripped by your email client :(
Care to try again?
thanks,
greg k-h
Sorry, this is the first patch that i ever submitted, next time I'll be more careful. The patch add the product id to support the zwave ZCU000-USB computer interface.
here is the patch:
drivers/usb/serial/ftdi_sio.c +1 -0
@@ -307,6 +307,7 @@static struct usb_device_id id_table_combined [] = { + {USB_DEVICE (FTDI_VID ,FTDI_ACTZWAVE_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_IRTRANS_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_SIO_PID ) }, {USB_DEVICE (FTDI_VID ,FTDI_8U232AM_PID ) },
drivers/usb/serial/ftdi_sio.h +4 -0
@@ -32,6 +32,10 @@#define FTDI_NF_RIC_PID 0x0001/* Product Id */ +/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */ +#define FTDI_ACTZWAVE_PID 0xF2D0 + +/* www.irtrans.de device */ #define FTDI_IRTRANS_PID 0xFC60/* Product Id */