pp_aula/spc.h
PATCH 1/1 pp_aula/spc.h
path_priority/pp_aula/spc.h
Isn't the inquiry_data.product_identifier 16 bytes long? or do I need a later draft of SPC3... 21d - Feb 2005 Bug doesn't effect existing code, but it's still a bug.
Rest looks ok, so far as I can tell.
See attached patch.
path_priority/pp_alua/spc3.h +2 -2
@@ -148,10 +148,10 @@ struct inquiry_data {/* ......x. = command queue support */ /* .......x = vs2 */ unsigned char vendor_identification[8 ]; -unsigned char product_identification[8 ]; +unsigned char product_identification[16 ];unsigned char product_revision[4 ];unsigned char vendor_specific[20 ]; -unsigned char b48;/* xxxx.... = reserved */ +unsigned char b56;/* xxxx.... = reserved */ /* ....xx.. = clocking */ /* ......x. = qas */ /* .......x = ius */
Quoted 18 lines · Tom Kalus
path_priority/pp_aula/spc.hIsn't the inquiry_data.product_identifier 16 bytes long? or do I need a later draft of SPC3... 21d - Feb 2005
Bug doesn't effect existing code, but it's still a bug.
Rest looks ok, so far as I can tell.See attached patch.
path_priority/pp_alua/spc3.h +0
-0@@ -148,10 +148,10 @@ struct inquiry_data {/* ......x. = command queue support */ /* .......x = vs2 */
path_priority/pp_alua/spc3.h struct inquiry_data { · line 157
Quoted 10 lines
path_priority/pp_alua/spc3.h +2
-2unsigned char vendor_identification[8 ]; -unsigned char product_identification[8 ]; +unsigned char product_identification[16 ];unsigned char product_revision[4 ];unsigned char vendor_specific[20 ]; -unsigned char b48;/* xxxx.... = reserved */ +unsigned char b56;/* xxxx.... = reserved */ /* ....xx.. = clocking */ /* ......x. = qas */ /* .......x = ius */
Stefan,
Can you you ack this one ?
Regards,
cvaroqui
The draft is good. This was/is a bug.
Mit freundlichem Gruß,
Stefan Bader
SW Linux on zSeries Development & Services [email protected]
----------------------------------------------------------------------------------
When all other means of communication fail, try words.
[email protected] wrote on 04.05.2006 16:56:45:
Quoted 4 lines · Tom Kalus
Quoted 3 lines
path_priority/pp_aula/spc.hIsn't the inquiry_data.product_identifier 16 bytes long? or do I need
a
Quoted 9 lines
Review
Quoted 9 lines
later draft of SPC3... 21d - Feb 2005
Bug doesn't effect existing code, but it's still a bug. Rest looks ok, so far as I can tell.See attached patch.
(quoted diff) +0
-0
b/path_priority/pp_alua/spc3.h
Quoted 28 lines
Quoted 6 lines
index 11f5dbd..bddbbdd 100644
path_priority/pp_alua/spc3.h +0
-0@@ -148,10 +148,10 @@ struct inquiry_data {/* ......x. = command queue support */ /* .......x = vs2 */ path_priority/pp_alua/spc3.h struct inquiry_data { · line 157
Quoted 10 lines
path_priority/pp_alua/spc3.h +2
-2unsigned char vendor_identification[8 ]; -unsigned char product_identification[8 ]; +unsigned char product_identification[16 ];unsigned char product_revision[4 ];unsigned char vendor_specific[20 ]; -unsigned char b48;/* xxxx.... = reserved */ +unsigned char b56;/* xxxx.... = reserved */ /* ....xx.. = clocking */ /* ......x. = qas */ /* .......x = ius */ Stefan,
Can you you ack this one ?
Regards,
cvaroqui--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel
Quoted 9 lines · Tom Kalus
path_priority/pp_aula/spc.hIsn't the inquiry_data.product_identifier 16 bytes long? or do I need a later draft of SPC3... 21d - Feb 2005
Bug doesn't effect existing code, but it's still a bug.
Rest looks ok, so far as I can tell.See attached patch.
Merged.
Thanks.