Skip to contentSkip to conversation

libnetfilter_conntrack: link extensions against libnfnetlink

PATCH New Philip Craig 1 participant 1 message May 17, 2006 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libnetfilter_conntrack: link extensions against libnfnetlink

The ulogd NFCT plugin fails to load libnetfilter_conntrack extensions unless they are linked against libnfnetlink. This problem may be specific to uClibc.

Also, a couple of questions about these makefiles:

Is there any reason to have a separate LIBADD for each extension?

Why is LIBS set in these files? This is normally a user defined variable, with the default value being determined by configure. And since we do a AC_CHECK_LIB for nfnetlink, the default LIBS already contains -lnfnetlink.

extensions/Makefile.am +4 -4
Index: libnetfilter_conntrack/extensions/Makefile.am
===================================================================
@@ -10,16 +10,16 @@
 
 nfct_proto_tcp_la_SOURCES = libnetfilter_conntrack_tcp.c
 nfct_proto_tcp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_tcp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_tcp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink
 
 nfct_proto_udp_la_SOURCES = libnetfilter_conntrack_udp.c
 nfct_proto_udp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_udp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_udp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink
 
 nfct_proto_icmp_la_SOURCES = libnetfilter_conntrack_icmp.c
 nfct_proto_icmp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_icmp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_icmp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink
 
 nfct_proto_sctp_la_SOURCES = libnetfilter_conntrack_sctp.c
 nfct_proto_sctp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_sctp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_sctp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink
l3extensions/Makefile.am +2 -2
Index: libnetfilter_conntrack/l3extensions/Makefile.am
===================================================================
@@ -9,8 +9,8 @@
 
 nfct_l3proto_ipv4_la_SOURCES = libnetfilter_conntrack_ipv4.c
 nfct_l3proto_ipv4_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_l3proto_ipv4_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_l3proto_ipv4_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink
 
 nfct_l3proto_ipv6_la_SOURCES = libnetfilter_conntrack_ipv6.c
 nfct_l3proto_ipv6_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_l3proto_ipv6_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_l3proto_ipv6_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink