Skip to contentSkip to conversation

x86_64: fix number of ia32 syscalls

PATCH In review Chuck Ebbert 5 participants 6 messages May 22, 2006 – May 23, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64: fix number of ia32 syscalls

Recent discussions about whether to print a message about unimplemented ia32 syscalls on x86_64 have missed the real bug: the number of ia32 syscalls is wrong in 2.6.16. Fixing that kills the message.

include/asm-x86_64/ia32_unistd.h +1 -1
@@ -317,6 +317,6 @@
 #define __NR_ia32_ppoll			309
 #define __NR_ia32_unshare		310
 
-#define IA32_NR_syscalls 315	/* must be > than biggest syscall! */
+#define IA32_NR_syscalls 311	/* must be > than biggest syscall! */
 
 #endif /* _ASM_X86_64_IA32_UNISTD_H_ */
Signature · 4 lines
Chuck

"The x86 isn't all that complex -- it just doesn't make a lot of sense."
                                                        -- Mike Johnson
#1 lore raw
Quoted 3 lines · Chuck Ebbert

Recent discussions about whether to print a message about unimplemented ia32 syscalls on x86_64 have missed the real bug: the number of ia32 syscalls is wrong in 2.6.16. Fixing that kills the message.

There is already a slightly different patch for this in the FF tree.

-Andi

#2 lore raw
Quoted 6 lines · * Andi Kleen ([email protected]) wrote:
Quoted 3 lines · Chuck Ebbert

Recent discussions about whether to print a message about unimplemented ia32 syscalls on x86_64 have missed the real bug: the number of ia32 syscalls is wrong in 2.6.16. Fixing that kills the message.

There is already a slightly different patch for this in the FF tree.

OK, if there's smth you think is good for -stable, just send it over.

thanks,
-chris

#3 lore raw
In reply to Andi Kleen
Quoted 7 lines · Andi Kleen
Quoted 3 lines · Chuck Ebbert

Recent discussions about whether to print a message about unimplemented ia32 syscalls on x86_64 have missed the real bug: the number of ia32 syscalls is wrong in 2.6.16. Fixing that kills the message.

There is already a slightly different patch for this in the FF tree.

Where is the FF tree?

--
Brian Gerst

#4 lore raw
Quoted 10 lines · Brian Gerst
Quoted 7 lines · Andi Kleen
Quoted 3 lines · Chuck Ebbert

Recent discussions about whether to print a message about unimplemented ia32 syscalls on x86_64 have missed the real bug: the number of ia32 syscalls is wrong in 2.6.16. Fixing that kills the message.

There is already a slightly different patch for this in the FF tree.

Where is the FF tree?

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/

-Andi

#5 lore raw
In reply to Chuck Ebbert

include/asm-x86_64/ia32_unistd.h line 320

Quoted 13 lines · you

Recent discussions about whether to print a message about unimplemented ia32 syscalls on x86_64 have missed the real bug: the number of ia32 syscalls is wrong in 2.6.16. Fixing that kills the message.

include/asm-x86_64/ia32_unistd.h +0 -1
@@ -317,6 +317,6 @@
 #define __NR_ia32_ppoll			309
 #define __NR_ia32_unshare		310
 
-#define IA32_NR_syscalls 315	/* must be > than biggest syscall! */

Maybe fix the comment so this is more clear, too?
/* must be biggest syscall + 1 */