affs: possible null pointer dereference in affs_rename()
PATCH 1/1 affs: possible null pointer dereference in affs_rename()
If affs_bread() fails, the exit path calls mark_buffer_dirty_inode() with a NULL argument.
Coverity CID: 312.
Signed-off-by Florin Malita <[email protected]>
---
fs/affs/namei.c +1 -2
@@ -416,10 +416,9 @@ affs_rename(struct inode *old_dir, strucreturn retval; } - retval = -EIO ; bh =affs_bread (sb, old_dentry->d_inode->i_ino);if (!bh) - goto done; +return -EIO ;/* Remove header from its parent directory. */ affs_lock_dir (old_dir);