Allow privcmd to support the _compat hypercalls
RFC PATCH 1/1 Allow privcmd to support the _compat hypercalls
Hi Keir,
I was encountering an odd error where Xend was tossing an EINVAL on xc_evtchn_alloc_unbound. After tracking it down, it turns out that this was because of an older userspace that was using the _compat version of the hypercalls.
Since the hypervisor still supports these calls, is there a compelling reason to not allow privcmd to expose these calls? If not, please apply the following patch.
Regards,
Anthony Liguori
# HG changeset patch
# User Anthony Liguori <[email protected]>
# Node ID daa038c99299f3770f6724b7e23f44451b36da3e
# Parent ad33b3882867f6ab4466383129aa3827c64508d3 Allow compat hypercalls to be made (to support older userspaces).
linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c +3 -0
@@ -267,6 +267,9 @@ static int __init privcmd_init(void)set_bit (__HYPERVISOR_mmuext_op, hypercall_permission_map);set_bit (__HYPERVISOR_xen_version, hypercall_permission_map);set_bit (__HYPERVISOR_sched_op, hypercall_permission_map); +set_bit (__HYPERVISOR_sched_op_compat, hypercall_permission_map); +set_bit (__HYPERVISOR_event_channel_op_compat, hypercall_permission_map); +set_bit (__HYPERVISOR_physdev_op_compat, hypercall_permission_map); privcmd_intf =create_xen_proc_entry ("privcmd" ,0400 );if (privcmd_intf !=NULL )
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel