Skip to contentSkip to conversation

irda: missing allocation result check in irlap_change_speed()

PATCH In review Florin Malita 2 participants 3 messages May 25, 2006 – May 26, 2006 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irda: missing allocation result check in irlap_change_speed()

The skb allocation may fail, which can result in a NULL pointer dereference in irlap_queue_xmit().

Coverity CID: 434.

---

net/irda/irlap.c +2 -1
index 7029618..a165286 100644
@@ -884,7 +884,8 @@ static void irlap_change_speed(struct ir
 	if (now) {
 		/* Send down empty frame to trigger speed change */
 		skb = dev_alloc_skb(0);
-		irlap_queue_xmit(self, skb);
+		if (skb)
+			irlap_queue_xmit(self, skb);
 	}
 }
 
maintainer
#1 lore raw

From: Florin Malita <[email protected]>
Date: Wed, 24 May 2006 20:13:26 -0400

Quoted 6 lines

The skb allocation may fail, which can result in a NULL pointer dereference in irlap_queue_xmit().

Coverity CID: 434.

If the allocation fails we should probably do something more interesting here, such as schedule a timer to try again later. Otherwise the speed change will silently never occur.

#2 lore raw
Quoted 5 lines · David Miller

If the allocation fails we should probably do something more interesting here, such as schedule a timer to try again later. Otherwise the speed change will silently never occur.

I thought the speed change would be piggybacked on the next frame, same as when 'now' == 0. Is that not the case?

	self->speed = speed;

	/* Change speed now, or just piggyback speed on frames */
	if (now) {
		/* Send down empty frame to trigger speed change */
		skb = dev_alloc_skb(0);
		if (skb)
			irlap_queue_xmit(self, skb);
	}