Skip to contentSkip to conversation

pppoe: missing result check in __pppoe_xmit()

PATCH New Florin Malita 1 participant 1 message May 31, 2006 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pppoe: missing result check in __pppoe_xmit()

skb_clone() may fail, we should check the result.

Coverity CID: 1215.

---

drivers/net/pppoe.c +3 -0
index 475dc93..0d101a1 100644
@@ -861,6 +861,9 @@ static int __pppoe_xmit(struct sock *sk,
 		 * give dev_queue_xmit something it can free.
 		 */
 		skb2 = skb_clone(skb, GFP_ATOMIC);
+
+		if (skb2 == NULL)
+			goto abort;
 	}
 
 	ph = (struct pppoe_hdr *) skb_push(skb2, sizeof(struct pppoe_hdr));