Skip to contentSkip to conversation

fbcon: Fix limited scroll in SCROLL_PAN_REDRAW mode

PATCH New Antonino A. Daplas 1 participant 1 message Jun 7, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbcon: Fix limited scroll in SCROLL_PAN_REDRAW mode

From: Malcom Parsons <[email protected]>

When scrolling up in SCROLL_PAN_REDRAW mode with a large limited scroll region, the bottom few lines have to be redrawn. Without this patch, the wrong text is drawn into these lines, corrupting the display.

Observed in 2.6.14 when running an IRC client in the Nintendo DS linux port.

I haven't tested if scrolling down has the same problem.

---

 drivers/video/console/fbcon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/console/fbcon.c +1 -1
index b910eff..4b7be68 100644
@@ -1751,7 +1751,7 @@ static int fbcon_scroll(struct vc_data *
 					fbcon_redraw_move(vc, p, 0, t, count);
 				ypan_up_redraw(vc, t, count);
 				if (vc->vc_rows - b > 0)
-					fbcon_redraw_move(vc, p, b - count,
+					fbcon_redraw_move(vc, p, b,
 							  vc->vc_rows - b, b);
 			} else
 				fbcon_redraw_move(vc, p, t + count, b - t - count, t);