Skip to contentSkip to conversation

ehea: Kconfig and Makefile

PATCH In review Jan-Bernd Themann 2 participants 2 messages Jun 7, 2006

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jan-Bernd Themann

author
#0 lore raw

PATCH 4/4 ehea: Kconfig and Makefile

Signed-off-by Jan-Bernd Themann <[email protected]>

drivers/net/ehea/Kconfig | 6 ++++++
drivers/net/ehea/Makefile | 45 +++++++++++++++++++++++++++++++++++++++++++++

2 files changed, 51 insertions(+)
drivers/net/ehea/Makefile 2006-06-07 07:01:14.634178704 -0700 renamed from drivers/net/ehea/Makefile 1969-12-31 16:00:00.000000000 -0800 +45 -0
@@ -0,0 +1,45 @@
+# Server eHEA ethernet device driver for Linux on POWER
+#
+#
+#  linux/drivers/net/ehea/Makefile
+#
+#  eHEA ethernet device driver for IBM eServer System p
+#
+#  (C) Copyright IBM Corp. 2006
+#
+#  Authors:
+#       Christoph Raisch <[email protected]>
+#       Jan-Bernd Themann <[email protected]>
+#       Heiko-Joerg Schick <[email protected]>
+#       Thomas Klein <[email protected]>
+#
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.     See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+
+
+
+# To compile module type:
+# make -C /root/linux-2.6.5-7.244 SUBDIRS=`pwd` V=1 modules CONFIG_EHEA=m
+# make -C /usr/src/linux-2.6.17-rc5 SUBDIRS=`pwd` V=1 modules CONFIG_EHEA=m
+
+ehea_mod-objs = ehea_main.o ehea_phyp.o ehea_qmr.o ehea_ethtool.o ehea_phyp.o
+
+obj-$(CONFIG_EHEA) += ehea_mod.o
+
+#CFLAGS += -Werror
+
+
+
drivers/net/ehea/Kconfig 2006-06-07 07:01:14.637178248 -0700 renamed from drivers/net/ehea/Kconfig 1969-12-31 16:00:00.000000000 -0800 +6 -0
@@ -0,0 +1,6 @@
+config EHEA
+       tristate "eHEA Ethernet support"
+       depends on IBMEBUS
+       ---help---
+       This driver supports the IBM pSeries
+       Ethernet adapter
#1 lore raw
Quoted 47 lines · On Wed, 07 Jun 2006 19:06:03 +0200 Jan-Bernd Themann wrote:
Signed-off-by Jan-Bernd Themann <[email protected]>

drivers/net/ehea/Kconfig | 6 ++++++
drivers/net/ehea/Makefile | 45 +++++++++++++++++++++++++++++++++++++++++++++

2 files changed, 51 insertions(+)
drivers/net/ehea/Makefile 2006-06-07 07:01:14.634178704 -0700 renamed from drivers/net/ehea/Makefile 1969-12-31 16:00:00.000000000 -0800 +35 -0
@@ -0,0 +1,45 @@
+# Server eHEA ethernet device driver for Linux on POWER
+#
+#
+#  linux/drivers/net/ehea/Makefile
+#
+#  eHEA ethernet device driver for IBM eServer System p
+#
+#  (C) Copyright IBM Corp. 2006
+#
+#  Authors:
+#       Christoph Raisch <[email protected]>
+#       Jan-Bernd Themann <[email protected]>
+#       Heiko-Joerg Schick <[email protected]>
+#       Thomas Klein <[email protected]>
+#
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.     See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+
+
+
+# To compile module type:
+# make -C /root/linux-2.6.5-7.244 SUBDIRS=`pwd` V=1 modules CONFIG_EHEA=m

drivers/net/ehea/Makefile 2006-06-07 07:01:14.634178704 -0700 line 45

Quoted 10 lines
drivers/net/ehea/Makefile 2006-06-07 07:01:14.634178704 -0700 renamed from drivers/net/ehea/Makefile 1969-12-31 16:00:00.000000000 -0800 +10 -0
+# make -C /usr/src/linux-2.6.17-rc5 SUBDIRS=`pwd` V=1 modules CONFIG_EHEA=m
+
+ehea_mod-objs = ehea_main.o ehea_phyp.o ehea_qmr.o ehea_ethtool.o ehea_phyp.o
+
+obj-$(CONFIG_EHEA) += ehea_mod.o
+
+#CFLAGS += -Werror
+
+
+

45 lines for a 5-line makefile. :(

You need to integrate the Makefile and Kconfig into the upper-level directory Makefile and Kconfig files. Don't expect/require people to enter thing like this:

drivers/net/ehea/Kconfig 2006-06-07 07:01:14.637178248 -0700 line 6

Quoted 13 lines
drivers/net/ehea/Makefile 2006-06-07 07:01:14.634178704 -0700 renamed from drivers/net/ehea/Makefile 1969-12-31 16:00:00.000000000 -0800 +2 -0
+# make -C /root/linux-2.6.5-7.244 SUBDIRS=`pwd` V=1 modules CONFIG_EHEA=m
+# make -C /usr/src/linux-2.6.17-rc5 SUBDIRS=`pwd` V=1 modules CONFIG_EHEA=m
drivers/net/ehea/Kconfig 2006-06-07 07:01:14.637178248 -0700 renamed from drivers/net/ehea/Kconfig 1969-12-31 16:00:00.000000000 -0800 +6 -0
@@ -0,0 +1,6 @@
+config EHEA
+       tristate "eHEA Ethernet support"
+       depends on IBMEBUS
+       ---help---
+       This driver supports the IBM pSeries
+       Ethernet adapter

That last sentence can be on one line, please.

---
~Randy