Skip to contentSkip to conversation

linux: move page table pinning out of context switch code

PATCH New Jan Beulich 1 participant 1 message Jun 13, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux: move page table pinning out of context switch code

This eliminates a deadlock and reduces (sometimes significantly) the time interrupts are off during context switch.

arch/i386/mm/pgtable-xen.c +6 -0
Index: head-2006-06-07/arch/i386/mm/pgtable-xen.c
===================================================================
@@ -614,6 +614,12 @@ void mm_pin_all(void)
 	}
 }
 
+void _arch_dup_mmap(struct mm_struct *mm)
+{
+	if (!test_bit(PG_pinned, &virt_to_page(mm->pgd)->flags))
+		mm_pin(mm);
+}
+
 void _arch_exit_mmap(struct mm_struct *mm)
 {
 	struct task_struct *tsk = current;
arch/x86_64/mm/pageattr-xen.c +6 -0
Index: head-2006-06-07/arch/x86_64/mm/pageattr-xen.c
===================================================================
@@ -130,6 +130,12 @@ void mm_pin_all(void)
 				  context.unpinned));
 }
 
+void _arch_dup_mmap(struct mm_struct *mm)
+{
+    if (!mm->context.pinned)
+        mm_pin(mm);
+}
+
 void _arch_exit_mmap(struct mm_struct *mm)
 {
     struct task_struct *tsk = current;
include/asm-i386/mach-xen/asm/mmu.h +4 -0
Index: head-2006-06-07/include/asm-i386/mach-xen/asm/mmu.h
===================================================================
@@ -18,4 +18,8 @@ typedef struct { 
 extern void _arch_exit_mmap(struct mm_struct *mm);
 #define arch_exit_mmap(_mm) _arch_exit_mmap(_mm)
 
+/* kernel/fork.c:dup_mmap hook */
+extern void _arch_dup_mmap(struct mm_struct *mm);
+#define arch_dup_mmap(mm, oldmm) ((void)(oldmm), _arch_dup_mmap(mm))
+
 #endif
include/asm-i386/mach-xen/asm/mmu_context.h +7 -4
Index: head-2006-06-07/include/asm-i386/mach-xen/asm/mmu_context.h
===================================================================
@@ -51,8 +51,7 @@ static inline void switch_mm(struct mm_s
 	struct mmuext_op _op[2], *op = _op;
 
 	if (likely(prev != next)) {
-		if (!test_bit(PG_pinned, &virt_to_page(next->pgd)->flags))
-			mm_pin(next);
+		BUG_ON(!test_bit(PG_pinned, &virt_to_page(next->pgd)->flags));
 
 		/* stop flush ipis for the previous mm */
 		cpu_clear(cpu, prev->cpu_vm_mask);
@@ -99,7 +98,11 @@ static inline void switch_mm(struct mm_s
 #define deactivate_mm(tsk, mm) \
 	asm("movl %0,%%fs ; movl %0,%%gs": :"r" (0))
 
-#define activate_mm(prev, next) \
-	switch_mm((prev),(next),NULL)
+static inline void activate_mm(struct mm_struct *prev, struct mm_struct *next)
+{
+	if (!test_bit(PG_pinned, &virt_to_page(next->pgd)->flags))
+		mm_pin(next);
+	switch_mm(prev, next, NULL);
+}
 
 #endif
include/asm-x86_64/mach-xen/asm/mmu.h +4 -0
Index: head-2006-06-07/include/asm-x86_64/mach-xen/asm/mmu.h
===================================================================
@@ -28,6 +28,10 @@ extern spinlock_t mm_unpinned_lock;
 /* mm/memory.c:exit_mmap hook */
 extern void _arch_exit_mmap(struct mm_struct *mm);
 #define arch_exit_mmap(_mm) _arch_exit_mmap(_mm)
+
+/* kernel/fork.c:dup_mmap hook */
+extern void _arch_dup_mmap(struct mm_struct *mm);
+#define arch_dup_mmap(mm, oldmm) ((void)(oldmm), _arch_dup_mmap(mm))
 #endif
 
 #endif
include/asm-x86_64/mach-xen/asm/mmu_context.h +7 -5
Index: head-2006-06-07/include/asm-x86_64/mach-xen/asm/mmu_context.h
===================================================================
@@ -73,8 +73,7 @@ static inline void switch_mm(struct mm_s
 	struct mmuext_op _op[3], *op = _op;
 
 	if (likely(prev != next)) {
-		if (!next->context.pinned)
-			mm_pin(next);
+		BUG_ON(!next->context.pinned);
 
 		/* stop flush ipis for the previous mm */
 		clear_bit(cpu, &prev->cpu_vm_mask);
@@ -127,8 +126,11 @@ static inline void switch_mm(struct mm_s
 	asm volatile("movl %0,%%fs"::"r"(0));  \
 } while(0)
 
-#define activate_mm(prev, next) do {		\
-	switch_mm((prev),(next),NULL);		\
-} while (0)
+static inline void activate_mm(struct mm_struct *prev, struct mm_struct *next)
+{
+	if (!next->context.pinned)
+		mm_pin(next);
+	switch_mm(prev, next, NULL);
+}
 
 #endif
kernel/fork.c +3 -0
Index: head-2006-06-07/kernel/fork.c
===================================================================
@@ -280,6 +280,9 @@ static inline int dup_mmap(struct mm_str
 		if (retval)
 			goto out;
 	}
+#ifdef arch_dup_mmap
+	arch_dup_mmap(mm, oldmm);
+#endif
 	retval = 0;
 out:
 	up_write(&mm->mmap_sem);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel