Skip to contentSkip to conversation

Cygwin git and windows network shares

DISCUSSION Niklas Frykholm 3 participants 6 messages Jun 15, 2016 1 message not in the archive

lore
Share & tools
lore

Niklas Frykholm

author
#0 lore raw

I'm trying to use cygwin git (compiled from the 1.4.0 tarball) to create repository on a windows network share, but I get an error message.

   $ cd //computer/git/project
   $ git init-db
   defaulting to local storage area
   Could not rename the lock file?

The repository seems to be left in an inconsistent state after this:

   $ git clone //computer/git/project/
   fatal: no matching remote head
   fetch-pack from '//computer/git/project/.git' failed.

When working only with local files, I do not get these errors. Does anyone know the cause of this error/any way around it?

// Niklas

#1 lore raw
Quoted 7 lines · Niklas Frykholm

I'm trying to use cygwin git (compiled from the 1.4.0 tarball) to create repository on a windows network share, but I get an error message.

    $ cd //computer/git/project
    $ git init-db
    defaulting to local storage area
    Could not rename the lock file?

cygwin's rename seems to be capable of overwriting an existing target only on NTFS. The following hack is a workaround, but is probably not safe.

lockfile.c +1 -0
index 2346e0e..5e78211 100644
@@ -48,6 +48,7 @@ int commit_lock_file(struct lock_file *l
 	strcpy(result_file, lk->filename);
 	i = strlen(result_file) - 5; /* .lock */
 	result_file[i] = 0;
+	unlink(result_file);
 	i = rename(lk->filename, result_file);
 	lk->filename[0] = 0;
 	return i;
#2 lore raw
Quoted 1 line · Juergen Ruehle

The following hack is a workaround, but is probably not safe.

Please just ignore it, it only helps on FAT32 partitions. Sorry for the confusion.

jr

#3 lore raw
In reply to Juergen Ruehle
Quoted 4 lines · Juergen Ruehle
Quoted 3 lines · Niklas Frykholm

I'm trying to use cygwin git (compiled from the 1.4.0 tarball) to create repository on a windows network share, but I get an error message.

Quoted 8 lines
Quoted 4 lines
    $ cd //computer/git/project
    $ git init-db
    defaulting to local storage area
    Could not rename the lock file?

cygwin's rename seems to be capable of overwriting an existing target only on NTFS. The following hack is a workaround, but is probably not safe.

Actually, Cygwin's rename has a specific check to make sure that the file is deleted. It tries very hard to do things the right way but if your samba server doesn't return the correct error code then it is possible that it could be confused.

cgf

#4 lore raw
Quoted 24 lines · Christopher Faylor
Quoted 4 lines · Juergen Ruehle
Quoted 3 lines · Niklas Frykholm

I'm trying to use cygwin git (compiled from the 1.4.0 tarball) to create repository on a windows network share, but I get an error message.

Quoted 8 lines
Quoted 4 lines
    $ cd //computer/git/project
    $ git init-db
    defaulting to local storage area
    Could not rename the lock file?

cygwin's rename seems to be capable of overwriting an existing target only on NTFS. The following hack is a workaround, but is probably not safe.

Actually, Cygwin's rename has a specific check to make sure that the file is deleted. It tries very hard to do things the right way but if your samba server doesn't return the correct error code then it is possible that it could be confused.

lockfile.c +0 -0
index 2346e0e..5e78211 100644

lockfile.c int commit_lock_file(struct lock_file *l · line 54

Quoted 7 lines
lockfile.c +1 -0
@@ -48,6 +48,7 @@ int commit_lock_file(struct lock_file *l
      strcpy(result_file, lk->filename);
      i = strlen(result_file) - 5; /* .lock */
      result_file[i] = 0;
+      unlink(result_file);
      i = rename(lk->filename, result_file);
      lk->filename[0] = 0;
      return i;

I also meant to ask if there was an i is nonzero after the call to the rename() above? If so, what was the errno? If not, it is a huge problem if rename is reporting that it is able to rename a file but is not actually doing it.

cgf
(cygwin maintainer)

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 20 lines · Juergen Ruehle
Quoted 4 lines · Christopher Faylor

I also meant to ask if there was an i is nonzero after the call to the rename() above? If so, what was the errno? If not, it is a huge problem if rename is reporting that it is able to rename a file but is not actually doing it.

After some testing the conclusion is that it's not lying, but only failing in interesting ways on my (and seemingly also Niklas') system:

- rename on NTFS succeeds (and returns 0)

- rename on FAT32 succeeds if target does not exist (and returns 0)

rename on FAT32 fails if target exists with EACCESS

(manual mv on commandline works)

- rename on a network share always hangs for a while and then fails with EBUSY (even if target does not exist)

Quoted 6 lines

(share served by XP, tested both NTFS and FAT32)

(manual mv still works)

Various combinations of server, ntsec, and smbntsec didn't seem to make a difference; /etc/{passwd,group} have been freshly created.

Thanks. I really appreciate the details. I've passed them on to the last person to touch the rename code.

cgf