Skip to contentSkip to conversation

fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh

PATCH In review Xu Wang 3 participants 3 messages Oct 10, 2014 – Oct 14, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Xu Wang

author
#1 lore raw

PATCH 1/1 fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh

From fbc38181f0504d5e92def922977da2dd0ae0ee8b Mon Sep 17 00:00:00 2001
From: George Wang <[email protected]>
Date: Fri, 10 Oct 2014 15:59:16 +0800
Subject: [PATCH] fs: Fix the check bug in
testcases/kernel/fs/acl/tacl_xattr.sh

Signed-off-by George Wang <[email protected]>
---
 testcases/kernel/fs/acl/tacl_xattr.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
testcases/kernel/fs/acl/tacl_xattr.sh +8 -8
index 99f6a95..5a60a04 100755
@@ -247,24 +247,24 @@ su - tacluser1 << TACL_USER1
    if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
    then
        echo ""
-       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
-       echo -e "\t permissions, but operation failed [ Physical Directory ]"
-   else
-       echo ""
        echo "SUCCESS: ACL_USER_OBJ  entry contains the owner write permissions,"
        echo -e "\t operation success [ Physical Directory ]"
+   else
+       echo ""
+       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
+       echo -e "\t permissions, but operation failed [ Physical Directory ]"
    fi
 
    touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null
    if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ]
    then
        echo ""
-       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
-       echo -e "\t permissions, but operation failed [ Symlink Directory ]"
-   else
-       echo ""
        echo "SUCCESS: ACL_USER_OBJ  entry contains the owner write permissions,"
        echo -e "\t operation success [ Symlink Directory ]"
+   else
+       echo ""
+       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
+       echo -e "\t permissions, but operation failed [ Symlink Directory ]"
    fi
 
 TACL_USER1
Signature · 23 lines
1.9.3

-- 
George Wang 王旭

Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom


------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#2 lore raw
Quoted 5 lines · Xu Wang

From fbc38181f0504d5e92def922977da2dd0ae0ee8b Mon Sep 17 00:00:00 2001
From: George Wang <[email protected]>
Date: Fri, 10 Oct 2014 15:59:16 +0800
Subject: [PATCH] fs: Fix the check bug in
testcases/kernel/fs/acl/tacl_xattr.sh

Can you please describe what bug you're trying to fix in commit log?

And you can use git send-email to send patch, as you did to the other patch :)

Thanks,
Eryu

Quoted 67 lines
Signed-off-by George Wang <[email protected]>
---
 testcases/kernel/fs/acl/tacl_xattr.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
testcases/kernel/fs/acl/tacl_xattr.sh +8 -8
index 99f6a95..5a60a04 100755
@@ -247,24 +247,24 @@ su - tacluser1 << TACL_USER1
    if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
    then
        echo ""
-       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
-       echo -e "\t permissions, but operation failed [ Physical Directory ]"
-   else
-       echo ""
        echo "SUCCESS: ACL_USER_OBJ  entry contains the owner write permissions,"
        echo -e "\t operation success [ Physical Directory ]"
+   else
+       echo ""
+       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
+       echo -e "\t permissions, but operation failed [ Physical Directory ]"
    fi
 
    touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null
    if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ]
    then
        echo ""
-       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
-       echo -e "\t permissions, but operation failed [ Symlink Directory ]"
-   else
-       echo ""
        echo "SUCCESS: ACL_USER_OBJ  entry contains the owner write permissions,"
        echo -e "\t operation success [ Symlink Directory ]"
+   else
+       echo ""
+       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the owner write "
+       echo -e "\t permissions, but operation failed [ Symlink Directory ]"
    fi
 
 TACL_USER1
Signature · 23 lines
1.9.3

-- 
George Wang 王旭

Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom


------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
In reply to Xu Wang

----- Original Message -----

testcases/kernel/fs/acl/tacl_xattr.sh su - tacluser1 << TACL_USER1

Quoted 22 lines

From: "Xu Wang" <[email protected]>
To: [email protected]
Sent: Friday, 10 October, 2014 10:06:48 AM
Subject: [LTP] [PATCH] fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh

From fbc38181f0504d5e92def922977da2dd0ae0ee8b Mon Sep 17 00:00:00 2001
From: George Wang <[email protected]>
Date: Fri, 10 Oct 2014 15:59:16 +0800
Subject: [PATCH] fs: Fix the check bug in
testcases/kernel/fs/acl/tacl_xattr.sh

Signed-off-by George Wang <[email protected]>
---
 testcases/kernel/fs/acl/tacl_xattr.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
testcases/kernel/fs/acl/tacl_xattr.sh +0 -0
index 99f6a95..5a60a04 100755
@@ -247,24 +247,24 @@ su - tacluser1 << TACL_USER1

Also I suspect that this line is a typo:
touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfil1 2> /dev/null
^^ test tries to touch "newfil1"
if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
^^ and then check for "newfile1"

Regards,
Jan

Quoted 52 lines
testcases/kernel/fs/acl/tacl_xattr.sh +0 -1
    if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
    then
        echo ""
-       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the

owner write "

testcases/kernel/fs/acl/tacl_xattr.sh +3 -3
-       echo -e "\t permissions, but operation failed [ Physical Directory ]"
-   else
-       echo ""
        echo "SUCCESS: ACL_USER_OBJ  entry contains the owner write
        permissions,"
        echo -e "\t operation success [ Physical Directory ]"
+   else
+       echo ""
+       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the

owner write "

testcases/kernel/fs/acl/tacl_xattr.sh +1 -1
+       echo -e "\t permissions, but operation failed [ Physical Directory ]"
    fi
 
    touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null
    if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ]
    then
        echo ""
-       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the

owner write "

testcases/kernel/fs/acl/tacl_xattr.sh +3 -3
-       echo -e "\t permissions, but operation failed [ Symlink Directory ]"
-   else
-       echo ""
        echo "SUCCESS: ACL_USER_OBJ  entry contains the owner write
        permissions,"
        echo -e "\t operation success [ Symlink Directory ]"
+   else
+       echo ""
+       echo "FAILED:  [ touch ] ACL_USER_OBJ  entry already contains the

owner write "
+ echo -e "\t permissions, but operation failed [ Symlink Directory ]"
fi

TACL_USER1
--
1.9.3

--
George Wang 王旭

Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom

Quoted 11 lines

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list