zoned-vm-stats-add-nr_anon.patch
Could we rename nr_mapped to something else if we're going to change it's meaning? Perhaps split nr_mapped into nr_mapped_file and nr_mapped_anon or something?
Otherwise any poor schmuck (eg me) who has to work across different kernel versions is going to get rather confused in the future.
In my mind, "nr_mapped" is a good name for the number of pages which are mapped, so excluding the anon pages from that seems to make the naming non-obvious. similarly, I presume we can have anon pages on transition to or from swap that are not mapped, and yet will not be reflected here, so nr_anon doesn't seem like a wholly accurate name to me either?
M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 3 lines · Martin Bligh
Could we rename
nr_mappedto something else if we're going to change it's meaning? Perhaps splitnr_mappedintonr_mapped_fileandnr_mapped_anonor something?
Yes we did that. nr_mapped was split into NR_MAPPED and NR_ANON. Please read the description for V4 if this patchset that was posted last week.
Quoted 5 lines
In my mind, "
nr_mapped" is a good name for the number of pages which are mapped, so excluding the anon pages from that seems to make the naming non-obvious. similarly, I presume we can have anon pages on transition to or from swap that are not mapped, and yet will not be reflected here, sonr_anondoesn't seem like a wholly
The same confusion exist for nr_dirty. Should we also rename nr_dirty to nr_dirty_file?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 9 lines · Christoph Lameter
Quoted 3 lines · Martin Bligh
Could we rename
nr_mappedto something else if we're going to change it's meaning? Perhaps splitnr_mappedintonr_mapped_fileandnr_mapped_anonor something?Yes we did that.
nr_mappedwas split intoNR_MAPPEDandNR_ANON. Please read the description for V4 if this patchset that was posted last week.
Yeah, but ... that's what I'm concerned about, the naming of it. Splitting it makes sense, just needs to be renamed something else, I think.
Quoted 7 lines
Quoted 5 lines
In my mind, "
nr_mapped" is a good name for the number of pages which are mapped, so excluding the anon pages from that seems to make the naming non-obvious. similarly, I presume we can have anon pages on transition to or from swap that are not mapped, and yet will not be reflected here, sonr_anondoesn't seem like a whollyThe same confusion exist for
nr_dirty. Should we also renamenr_dirtytonr_dirty_file?
Sure. Naming is important, IMHO. People reading code make involuntary assumptions as they read code, it's inevitable.
M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 2 lines · Martin Bligh
Sure. Naming is important, IMHO. People reading code make involuntary assumptions as they read code, it's inevitable.
Ok. I will make a pass over all the counter before sending the next patchset to Andrew and make sure that they get a proper suffix if their role is restricted.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 8 lines · Christoph Lameter
Quoted 2 lines · Martin Bligh
Sure. Naming is important, IMHO. People reading code make involuntary assumptions as they read code, it's inevitable.
Ok. I will make a pass over all the counter before sending the next patchset to Andrew and make sure that they get a proper suffix if their role is restricted.
Awesome - thanks very much.
M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>