Skip to contentSkip to conversation

3w-9xyz: add proc_name

PATCH In review Randy Dunlap 2 participants 3 messages Jun 21, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 3w-9xyz: add proc_name

Add .proc_name member to scsi_host_template for 3w-9xxx.

http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=12fdf64086335ed596848cf17602e7a71e15ae9b

---
 drivers/scsi/3w-9xxx.c |    1 +
 1 file changed, 1 insertion(+)
drivers/scsi/3w-9xxx.c +1 -0
@@ -2011,6 +2011,7 @@ static void twa_unmap_scsi_data(TW_Devic
 /* scsi_host_template initializer */
 static struct scsi_host_template driver_template = {
 	.module			= THIS_MODULE,
+	.proc_name		= "3w-9xxx",
 	.name			= "3ware 9000 Storage Controller",
 	.queuecommand		= twa_scsi_queue,
 	.eh_host_reset_handler	= twa_scsi_eh_reset,
maintainer
#1 lore raw

Randy,

Is there any reason why any of these proc_name patches need to go in after James Smart's explanation:

http://marc.theaimsgroup.com/?l=linux-scsi&m=115040210406375&w=2

in particular, the part about:

"- scsi_proc_hostdir_add() validates that sht->proc_info is non-null before
attempting to use sht->proc_name."

proc_info is null for the 3w-9xxx driver.

-Adam

Quoted 27 lines · Randy Dunlap

Add .proc_name member to scsi_host_template for 3w-9xxx.

http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=12fdf64086335ed596848cf17602e7a71e15ae9b

---
 drivers/scsi/3w-9xxx.c |    1 +
 1 file changed, 1 insertion(+)
drivers/scsi/3w-9xxx.c +1 -1
@@ -2011,6 +2011,7 @@ static void twa_unmap_scsi_data(TW_Devic
 /* scsi_host_template initializer */
 static struct scsi_host_template driver_template = {
        .module                 = THIS_MODULE,
+       .proc_name              = "3w-9xxx",
        .name                   = "3ware 9000 Storage Controller",
        .queuecommand           = twa_scsi_queue,
        .eh_host_reset_handler  = twa_scsi_eh_reset,
 
 
 
-

To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 4 lines · adam radford

Randy,

Is there any reason why any of these proc_name patches need to go in after James Smart's explanation:

Nope. Thanks for your comments.

~Randy

Quoted 36 lines

http://marc.theaimsgroup.com/?l=linux-scsi&m=115040210406375&w=2

in particular, the part about:

"- scsi_proc_hostdir_add() validates that sht->proc_info is non-null before
attempting to use sht->proc_name."

proc_info is null for the 3w-9xxx driver.

-Adam

Quoted 24 lines · Randy Dunlap

Add .proc_name member to scsi_host_template for 3w-9xxx.

http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=12fdf64086335ed596848cf17602e7a71e15ae9b

---
 drivers/scsi/3w-9xxx.c |    1 +
 1 file changed, 1 insertion(+)
drivers/scsi/3w-9xxx.c +1 -1
@@ -2011,6 +2011,7 @@ static void twa_unmap_scsi_data(TW_Devic
 /* scsi_host_template initializer */
 static struct scsi_host_template driver_template = {
        .module                 = THIS_MODULE,
+       .proc_name              = "3w-9xxx",
        .name                   = "3ware 9000 Storage Controller",
        .queuecommand           = twa_scsi_queue,
        .eh_host_reset_handler  = twa_scsi_eh_reset,
 
 
 
-