Skip to contentSkip to conversation

cdrom support with thinkpad x6 ultrabay

DISCUSSION George Nychis 4 participants 9 messages Jun 15, 2006 – Jun 23, 2006

lore
Share & tools
lore
#0 lore raw

Hi,

I am looking for support somewhere in the kernel for my thinkpad x6 ultrabay's cdrom drive. Whenever I attach the ultrabay it picks up the extra usb ports, seems to pick up the ethernet port, but it fails to pick up anything about the dvd/cd-writer. Nothing shows up in dmesg about the drive at all... anyone know what I might need in the kernel? I am using 2.6.17-rc6

Thanks!
George

#1 lore raw
Quoted 8 lines · On Thu, 15 Jun 2006 00:52:06 -0400 George Nychis wrote:

Hi,

I am looking for support somewhere in the kernel for my thinkpad x6 ultrabay's cdrom drive. Whenever I attach the ultrabay it picks up the extra usb ports, seems to pick up the ethernet port, but it fails to pick up anything about the dvd/cd-writer. Nothing shows up in dmesg about the drive at all... anyone know what I might need in the kernel? I am using 2.6.17-rc6

I'm not sure, but you may need the dock station driver patches that are in -mm. You could try 2.6.17-rc6-mm2 ...

---
~Randy

#2 lore raw
In reply to George Nychis
Quoted 6 lines · George Nychis

I am looking for support somewhere in the kernel for my thinkpad x6 ultrabay's cdrom drive. Whenever I attach the ultrabay it picks up the extra usb ports, seems to pick up the ethernet port, but it fails to pick up anything about the dvd/cd-writer. Nothing shows up in dmesg about the drive at all... anyone know what I might need in the kernel? I am using 2.6.17-rc6

-mm has some support for the dock, but there isn't support for hot add/remove of the optical device yet. I think that's waiting on some support in libata, but I'm not exactly sure what's needed.

At the moment, you either get the dock optical if you boot the machine in the dock, and you can never eject the dock, or you get no optical and eject works fine.

J

#3 lore raw
Quoted 11 lines · Jeremy Fitzhardinge
Quoted 6 lines · George Nychis

I am looking for support somewhere in the kernel for my thinkpad x6 ultrabay's cdrom drive. Whenever I attach the ultrabay it picks up the extra usb ports, seems to pick up the ethernet port, but it fails to pick up anything about the dvd/cd-writer. Nothing shows up in dmesg about the drive at all... anyone know what I might need in the kernel? I am using 2.6.17-rc6

-mm has some support for the dock, but there isn't support for hot add/remove of the optical device yet. I think that's waiting on some support in libata, but I'm not exactly sure what's needed.

Quoted 6 lines

At the moment, you either get the dock optical if you boot the machine in the dock, and you can never eject the dock, or you get no optical and eject works fine.

J

Thanks for the responses Jeremy and Randy.

I tried taking the acpi dock patch seperately out of the mm patchset by applying this patch:
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc6/2.6.17-rc6-mm1/broken-out/acpi-dock-driver.patch

it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to be set, so I did a "make oldconfig" after applying the patch, expecting it to ask me whether or not i wanted to support it... it didn't. So then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the kernel, but dock.o is never built... what else do i need to do?

If i can't get hot swappable support yet, I might as well get what is supported for now so I can atleast use it sometimes :)

Maybe this cry for help will spark someone to finish off the work on hot swapping the optical drive.

Thanks!
George

#4 lore raw
Quoted 6 lines · George Nychis

it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to be set, so I did a "make oldconfig" after applying the patch, expecting it to ask me whether or not i wanted to support it... it didn't. So then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the kernel, but dock.o is never built... what else do i need to do?

Make sure you disable the (obsolete?) ACPI_IBM_DOCK stuff.

Quoted 6 lines

If i can't get hot swappable support yet, I might as well get what is supported for now so I can atleast use it sometimes :)

Maybe this cry for help will spark someone to finish off the work on hot swapping the optical drive.

Yeah, I'm hoping all the work on power management in libata will make things "just work" soon, but I think there's more to it. When you press the dock eject button, it really needs to go out to acpid, activate a script to unmount any filesystems mounted off the device, and then poke the ata layer to remove the device, before OKing the dock eject so the hardware's "don't do that" light goes out.

But in the meantime I'm having enough trouble getting plain old suspend/resume reliable.

J

#5 lore raw

I applied the acpi-dock patch that I specified, and that patch only, and i'm getting errors building:

drivers/acpi/dock.c: In function 'dock_notify':
drivers/acpi/dock.c:543: error: 'KOBJ_DOCK' undeclared (first use in this function)
drivers/acpi/dock.c:543: error: (Each undeclared identifier is reported only once
drivers/acpi/dock.c:543: error: for each function it appears in.) drivers/acpi/dock.c:562: error: 'KOBJ_UNDOCK' undeclared (first use in this function)

Is there something else I need to apply that I am missing?

Thanks!
George

Quoted 29 lines · Jeremy Fitzhardinge
Quoted 6 lines · George Nychis

it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to be set, so I did a "make oldconfig" after applying the patch, expecting it to ask me whether or not i wanted to support it... it didn't. So then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the kernel, but dock.o is never built... what else do i need to do?

Make sure you disable the (obsolete?) ACPI_IBM_DOCK stuff.

Quoted 6 lines

If i can't get hot swappable support yet, I might as well get what is supported for now so I can atleast use it sometimes :)

Maybe this cry for help will spark someone to finish off the work on hot swapping the optical drive.

Yeah, I'm hoping all the work on power management in libata will make things "just work" soon, but I think there's more to it. When you press the dock eject button, it really needs to go out to acpid, activate a script to unmount any filesystems mounted off the device, and then poke the ata layer to remove the device, before OKing the dock eject so the hardware's "don't do that" light goes out.

But in the meantime I'm having enough trouble getting plain old suspend/resume reliable.

J

#6 lore raw
Quoted 12 lines · George Nychis

I applied the acpi-dock patch that I specified, and that patch only, and i'm getting errors building:

drivers/acpi/dock.c: In function 'dock_notify':
drivers/acpi/dock.c:543: error: 'KOBJ_DOCK' undeclared (first use in this function)
drivers/acpi/dock.c:543: error: (Each undeclared identifier is reported only once
drivers/acpi/dock.c:543: error: for each function it appears in.) drivers/acpi/dock.c:562: error: 'KOBJ_UNDOCK' undeclared (first use in this function)

Quoted 2 lines

Is there something else I need to apply that I am missing?

Kristen?

J

Quoted 38 lines

Thanks!
George

Quoted 32 lines · Jeremy Fitzhardinge
Quoted 7 lines · George Nychis

it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to be set, so I did a "make oldconfig" after applying the patch, expecting it to ask me whether or not i wanted to support it... it didn't. So then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the kernel, but dock.o is never built... what else do i need to do?

Make sure you disable the (obsolete?) ACPI_IBM_DOCK stuff.

Quoted 7 lines

If i can't get hot swappable support yet, I might as well get what is supported for now so I can atleast use it sometimes :)

Maybe this cry for help will spark someone to finish off the work on hot swapping the optical drive.

Yeah, I'm hoping all the work on power management in libata will make things "just work" soon, but I think there's more to it. When you press the dock eject button, it really needs to go out to acpid, activate a script to unmount any filesystems mounted off the device, and then poke the ata layer to remove the device, before OKing the dock eject so the hardware's "don't do that" light goes out.

But in the meantime I'm having enough trouble getting plain old suspend/resume reliable.

J

#7 lore raw

any update on this? anyone else have a clue?

Thanks!
George

Quoted 57 lines · Jeremy Fitzhardinge
Quoted 12 lines · George Nychis

I applied the acpi-dock patch that I specified, and that patch only, and i'm getting errors building:

drivers/acpi/dock.c: In function 'dock_notify':
drivers/acpi/dock.c:543: error: 'KOBJ_DOCK' undeclared (first use in this function)
drivers/acpi/dock.c:543: error: (Each undeclared identifier is reported only once
drivers/acpi/dock.c:543: error: for each function it appears in.) drivers/acpi/dock.c:562: error: 'KOBJ_UNDOCK' undeclared (first use in this function)

Quoted 2 lines

Is there something else I need to apply that I am missing?

Kristen?

J

Quoted 37 lines

Thanks!
George

Quoted 31 lines · Jeremy Fitzhardinge
Quoted 6 lines · George Nychis

it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to be set, so I did a "make oldconfig" after applying the patch, expecting it to ask me whether or not i wanted to support it... it didn't. So then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the kernel, but dock.o is never built... what else do i need to do?

Make sure you disable the (obsolete?) ACPI_IBM_DOCK stuff.

Quoted 7 lines

If i can't get hot swappable support yet, I might as well get what is supported for now so I can atleast use it sometimes :)

Maybe this cry for help will spark someone to finish off the work on hot
swapping the optical drive.

Yeah, I'm hoping all the work on power management in libata will make things "just work" soon, but I think there's more to it. When you press the dock eject button, it really needs to go out to acpid, activate a script to unmount any filesystems mounted off the device, and then poke the ata layer to remove the device, before OKing the dock eject so the hardware's "don't do that" light goes out.

But in the meantime I'm having enough trouble getting plain old suspend/resume reliable.

J

#8 lore raw
Quoted 72 lines · George Nychis

any update on this? anyone else have a clue?

Thanks!
George

Quoted 64 lines · Jeremy Fitzhardinge
Quoted 12 lines · George Nychis

I applied the acpi-dock patch that I specified, and that patch only, and i'm getting errors building:

drivers/acpi/dock.c: In function 'dock_notify':
drivers/acpi/dock.c:543: error: 'KOBJ_DOCK' undeclared (first use in this function)
drivers/acpi/dock.c:543: error: (Each undeclared identifier is reported only once
drivers/acpi/dock.c:543: error: for each function it appears in.) drivers/acpi/dock.c:562: error: 'KOBJ_UNDOCK' undeclared (first use in this function)

Quoted 3 lines

Is there something else I need to apply that I am missing?

Kristen?

J

Quoted 43 lines

Thanks!
George

Quoted 36 lines · Jeremy Fitzhardinge
Quoted 7 lines · George Nychis

it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to be set, so I did a "make oldconfig" after applying the patch, expecting it to ask me whether or not i wanted to support it... it didn't. So then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the kernel, but dock.o is never built... what else do i need to do?

Make sure you disable the (obsolete?) ACPI_IBM_DOCK stuff.

Quoted 8 lines

If i can't get hot swappable support yet, I might as well get what is supported for now so I can atleast use it sometimes :)

Maybe this cry for help will spark someone to finish off the work on hot
swapping the optical drive.

Yeah, I'm hoping all the work on power management in libata will make things "just work" soon, but I think there's more to it. When you press the dock eject button, it really needs to go out to acpid, activate a script to unmount any filesystems mounted off the device, and then poke the ata layer to remove the device, before OKing the dock eject so the hardware's "don't do that" light goes out.

But in the meantime I'm having enough trouble getting plain old suspend/resume reliable.

J

Hi, sorry for the delay in responding - I am out of town at the moment and have sporadic access to email.

You are indeed missing a patch that you need:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm3/broken-out/kevent-add-new-uevent.patch

If you have any PCI devices, you also need the patches to acpiphp:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm3/broken-out/acpiphp-use-new-dock-driver.patch