via-ircc: fix memory leak

PATCH New Randy Dunlap 1 participant 1 message Jul 3, 2006

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Randy Dunlap

author

2006-07-03 20:46 UTC #0 lore raw

PATCH 1/1 via-ircc: fix memory leak

From: Chuck Short <chuck@maggie>

[UBUNTU: via-ircc] Fix memory leak.

Coverity id# 653

patch location:
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78

Signed-off-by Chuck Short <[email protected]>

Signed-off-by Ben Collins <[email protected]>

---
 drivers/net/irda/via-ircc.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

drivers/net/irda/via-ircc.c +6 -1

@@ -1220,8 +1220,13 @@ static int upload_rxdata(struct via_ircc
 
 	IRDA_DEBUG(2, "%s(): len=%x\n", __FUNCTION__, len);
 
+	if ((len - 4) < 2) {
+		self->stats.rx_dropped++;
+		return FALSE;
+	}
+
 	skb = dev_alloc_skb(len + 1);
-	if ((skb == NULL) || ((len - 4) < 2)) {
+	if (skb == NULL) {
 		self->stats.rx_dropped++;
 		return FALSE;
 	}