Do not dump everything on new conntracks events

PATCH In review Pablo Neira Ayuso 1 participant 1 message Jul 7, 2006

Subsystems (2)

Networking netfilter

lore

Share & tools

lore

Pablo Neira Ayuso

author maintainer

2006-07-07 02:16 UTC #0 lore raw

PATCH 8/10 Do not dump everything on new conntracks events

Just dump what has been explicitely set in the event cache.

Signed-off-by Pablo Neira Ayuso <[email protected]>

Signature · 2 lines

The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

[CTNETLINK] Do not dump everything on new conntracks events

Just dump what has been explicitely set in the event cache.

Signed-off-by Pablo Neira Ayuso <[email protected]>

net/ipv4/netfilter/ip_conntrack_netlink.c +0 -2

Index: net-2.6/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
@@ -326,8 +326,6 @@
 	} else if (events & (IPCT_NEW | IPCT_RELATED)) {
 		type = IPCTNL_MSG_CT_NEW;
 		flags = NLM_F_CREATE|NLM_F_EXCL;
-		/* dump everything */
-		events = ~0UL;
 		group = NFNLGRP_CONNTRACK_NEW;
 	} else if (events & (IPCT_STATUS |
 		      IPCT_PROTOINFO |

net/netfilter/nf_conntrack_netlink.c +0 -2

Index: net-2.6/net/netfilter/nf_conntrack_netlink.c
===================================================================
@@ -336,8 +336,6 @@
 	} else  if (events & (IPCT_NEW | IPCT_RELATED)) {
 		type = IPCTNL_MSG_CT_NEW;
 		flags = NLM_F_CREATE|NLM_F_EXCL;
-		/* dump everything */
-		events = ~0UL;
 		group = NFNLGRP_CONNTRACK_NEW;
 	} else  if (events & (IPCT_STATUS |
 		      IPCT_PROTOINFO |