drivers/base: Platform notify needs to occur before drivers attach to the device

PATCH New Brian Walsh 1 participant 1 message Jul 10, 2006 Driver core

Share & tools

Brian Walsh

author

2006-07-10 19:51 UTC #0 lore raw

PATCH 1/1 drivers/base: Platform notify needs to occur before drivers attach to the device

The platform_notify call for Arm and PPC architectures needs to be called before the driver attaches to the device. The problem only presents itself when hotplugging certain devices while the driver is already loaded.

Signed-off-by Brian Walsh <[email protected]>

---

drivers/base/core.c 2006-07-10 13:32:58.000000000 -0400 renamed from drivers/base/core.c 2006-07-10 13:26:00.000000000 -0400 +4 -4

diff -ur a/drivers/base/core.c b/drivers/base/core.c
@@ -307,6 +307,10 @@
        if ((error = kobject_add(&dev->kobj)))
                goto Error;
 
+       /* notify platform of device entry */
+       if (platform_notify)
+               platform_notify(dev);
+
        dev->uevent_attr.attr.name = "uevent";
        dev->uevent_attr.attr.mode = S_IWUSR;
        if (dev->driver)

@@ -361,10 +365,6 @@
                list_add_tail(&dev->node, &dev->class->devices);
                up(&dev->class->sem);
        }
-
-       /* notify platform of device entry */
-       if (platform_notify)
-               platform_notify(dev);
  Done:
        kfree(class_name);
        put_device(dev);