Skip to contentSkip to conversation

net48xx LED cleanups

PATCH In review Chris Boot 1 participant 2 messages Jul 11, 2006

Subsystems (2)
LED Soekris NET48XX LED support
lore
Share & tools
lore

Chris Boot

author maintainer
#0 lore raw

PATCH 1/1 net48xx LED cleanups

Add the DRVNAME define to remove the two separate references of the driver name by string, and move the .driver.owner into the existing .driver sub-structure (or whatever it's called).

Signed-off-by Chris Boot <[email protected]>
drivers/leds/leds-net48xx.c +4 -3
index 35ee52f..713c4a8 100644
@@ -18,6 +18,7 @@
 #include <asm/io.h>
 #include <linux/scx200_gpio.h>
 
+#define DRVNAME "net48xx-led"
 #define NET48XX_ERROR_LED_GPIO	20
 
 static struct platform_device *pdev;

@@ -66,13 +67,13 @@ static int net48xx_led_remove(struct pla
 }
 
 static struct platform_driver net48xx_led_driver = {
-	.driver.owner	= THIS_MODULE,
 	.probe		= net48xx_led_probe,
 	.remove		= net48xx_led_remove,
 	.suspend	= net48xx_led_suspend,
 	.resume		= net48xx_led_resume,
 	.driver		= {
-		.name = "net48xx-led",
+		.name		= DRVNAME,
+		.owner		= THIS_MODULE,
 	},
 };
 

@@ -89,7 +90,7 @@ static int __init net48xx_led_init(void)
 	if (ret < 0)
 		goto out;
 
-	pdev = platform_device_register_simple("net48xx-led", -1, NULL, 0);
+	pdev = platform_device_register_simple(DRVNAME, -1, NULL, 0);
 	if (IS_ERR(pdev)) {
 		ret = PTR_ERR(pdev);
 		platform_driver_unregister(&net48xx_led_driver);
Signature · 3 lines
Chris Boot
[email protected]
http://www.bootc.net/
author maintainer
#1 lore raw
Quoted 3 lines · Chris Boot

Add the DRVNAME define to remove the two separate references of the driver name by string, and move the .driver.owner into the existing .driver sub-structure (or whatever it's called).

Signed-off-by Chris Boot <[email protected]>

Never trust Thunderbird. Attached.

Signature · 3 lines
Chris Boot
[email protected]
http://www.bootc.net/
drivers/leds/leds-net48xx.c +4 -3
index 35ee52f..713c4a8 100644
@@ -18,6 +18,7 @@
 #include <asm/io.h>
 #include <linux/scx200_gpio.h>
 
+#define DRVNAME "net48xx-led"
 #define NET48XX_ERROR_LED_GPIO	20
 
 static struct platform_device *pdev;

@@ -66,13 +67,13 @@ static int net48xx_led_remove(struct pla
 }
 
 static struct platform_driver net48xx_led_driver = {
-	.driver.owner	= THIS_MODULE,
 	.probe		= net48xx_led_probe,
 	.remove		= net48xx_led_remove,
 	.suspend	= net48xx_led_suspend,
 	.resume		= net48xx_led_resume,
 	.driver		= {
-		.name = "net48xx-led",
+		.name		= DRVNAME,
+		.owner		= THIS_MODULE,
 	},
 };
 

@@ -89,7 +90,7 @@ static int __init net48xx_led_init(void)
 	if (ret < 0)
 		goto out;
 
-	pdev = platform_device_register_simple("net48xx-led", -1, NULL, 0);
+	pdev = platform_device_register_simple(DRVNAME, -1, NULL, 0);
 	if (IS_ERR(pdev)) {
 		ret = PTR_ERR(pdev);
 		platform_driver_unregister(&net48xx_led_driver);