Skip to contentSkip to conversation

Success: tty_io flush_to_ldisc() error message triggered

PATCH Chuck Ebbert 2 participants 3 messages Jul 22, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Using the patch below that you sent me, this message printed today on my SMP system when terminating pppd:

flush_to_ldisc - TTY_FLUSHING set, low_latency=0

And this bug is also in 2.6.17.4 - I forgot to reboot into 2.6.16.x and the system locked up the same way 2.6.16 used to. That was made even more fun by the 'SysRq broken on SMP' bug fixed by a pending 2.6.17.7 patch...

include/linux/tty.h +1 -0
@@ -266,6 +266,7 @@ struct tty_struct {
 #define TTY_PTY_LOCK 		16	/* pty private */
 #define TTY_NO_WRITE_SPLIT 	17	/* Preserve write boundaries to driver */
 #define TTY_HUPPED 		18	/* Post driver->hangup() */
+#define TTY_FLUSHING 		19	/* Flushing tty buffers to line discipline */
 
 #define TTY_WRITE_FLUSH(tty) tty_write_flush((tty))
 
drivers/char/tty_io.c +7 -3
@@ -2781,9 +2781,12 @@ static void flush_to_ldisc(void *private
 		return;
 
 	if (test_bit(TTY_DONT_FLIP, &tty->flags)) {
-		/*
-		 * Do it after the next timer tick:
-		 */
+		printk(KERN_ERR"flush_to_ldisc - TTY_DONT_FLIP set\n");
+		schedule_delayed_work(&tty->buf.work, 1);
+		goto out;
+	}
+	if (test_and_set_bit(TTY_FLUSHING, &tty->flags)) {
+		printk(KERN_ERR"flush_to_ldisc - TTY_FLUSHING set, low_latency=%d\n", tty->low_latency);
 		schedule_delayed_work(&tty->buf.work, 1);
 		goto out;
 	}
@@ -2805,6 +2808,7 @@ static void flush_to_ldisc(void *private
 		tty_buffer_free(tty, tbuf);
 	}
 	spin_unlock_irqrestore(&tty->buf.lock, flags);
+	clear_bit(TTY_FLUSHING, &tty->flags);
 out:
 	tty_ldisc_deref(disc);
 }
Signature · 1 line
Chuck
#1 lore raw
Quoted 9 lines · Chuck Ebbert

Using the patch below that you sent me, this message printed today on my SMP system when terminating pppd:

flush_to_ldisc - TTY_FLUSHING set, low_latency=0

And this bug is also in 2.6.17.4 - I forgot to reboot into 2.6.16.x and the system locked up the same way 2.6.16 used to. That was made even more fun by the 'SysRq broken on SMP' bug fixed by a pending 2.6.17.7 patch...

That confirms my thoughts on what went wrong:
multiple copies of the queued work (flush_to_ldisc) running in parallel and corrupting the free buffer list.

A cleaner fix for this is already
in the 2.6.18 rc series.

Thanks,
Paul

--
Paul Fulghum
Microgate Systems, Ltd.

#2 lore raw
In reply to Chuck Ebbert
Quoted 9 lines · Chuck Ebbert

Using the patch below that you sent me, this message printed today on my SMP system when terminating pppd:

flush_to_ldisc - TTY_FLUSHING set, low_latency=0

And this bug is also in 2.6.17.4 - I forgot to reboot into 2.6.16.x and the system locked up the same way 2.6.16 used to. That was made even more fun by the 'SysRq broken on SMP' bug fixed by a pending 2.6.17.7 patch...

That confirms my thoughts on what went wrong:
multiple copies of the queued work (flush_to_ldisc) running in parallel and corrupting the free buffer list.

A cleaner fix for this is already
in the 2.6.18 rc series.

Thanks,
Paul

--
Paul Fulghum
Microgate Systems, Ltd.