: Fix protocol field value for outgoing IPv6 GSO packets
Subsystems (3)
This appears to be a mistake, but I didn't follow the GSO stuff very closely, so there could be some non-obvious reason.
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
---
commit 8035f60a607630459e4440dbbc5a20f3cfbf97ac
tree f1a7061cfd1f923b3991ee8f449cffce86870a3e
parent 440848a8e33fc1927bab45bd73f6c8e042ea7abd
author Patrick McHardy <[email protected]> Tue, 25 Jul 2006 02:02:00 +0200 committer Patrick McHardy <[email protected]> Tue, 25 Jul 2006 02:02:00 +0200
net/ipv6/xfrm6_output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv6/xfrm6_output.c +1 -1
@@ -125,7 +125,7 @@ static int xfrm6_output_finish(struct skif (!skb_is_gso (skb))return xfrm6_output_finish2 (skb); - skb->protocol =htons (ETH_P_IP ); + skb->protocol =htons (ETH_P_IPV6 ); segs =skb_gso_segment (skb,0 );kfree_skb (skb);if (unlikely (IS_ERR (segs)))
Quoted 2 lines · Patrick McHardy
This appears to be a mistake, but I didn't follow the GSO stuff very closely, so there could be some non-obvious reason.
Yes it definitely was a mistake! Thanks for picking this up Patrick.
Quoted 3 lines
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
Signed-off-by Patrick McHardy <[email protected]>
Cheers,
Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txtFrom: Herbert Xu <[email protected]>
Date: Tue, 25 Jul 2006 10:13:26 +1000
Quoted 11 lines · Patrick McHardy
Quoted 2 lines
This appears to be a mistake, but I didn't follow the GSO stuff very closely, so there could be some non-obvious reason.
Yes it definitely was a mistake! Thanks for picking this up Patrick.
Quoted 3 lines
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
Signed-off-by Patrick McHardy <[email protected]>Acked-by Herbert Xu <[email protected]>
Applied, thanks guys.
Hi Dave,
Quoted 7 lines · Herbert Xu
Quoted 3 lines · Patrick McHardy
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
Signed-off-by Patrick McHardy <[email protected]>Acked-by Herbert Xu <[email protected]>
I believe you missed this one. Attached again for your convenience.
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
---
commit 8035f60a607630459e4440dbbc5a20f3cfbf97ac
tree f1a7061cfd1f923b3991ee8f449cffce86870a3e
parent 440848a8e33fc1927bab45bd73f6c8e042ea7abd
author Patrick McHardy <[email protected]> Tue, 25 Jul 2006 02:02:00 +0200 committer Patrick McHardy <[email protected]> Tue, 25 Jul 2006 02:02:00 +0200
net/ipv6/xfrm6_output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv6/xfrm6_output.c +1 -1
@@ -125,7 +125,7 @@ static int xfrm6_output_finish(struct skif (!skb_is_gso (skb))return xfrm6_output_finish2 (skb); - skb->protocol =htons (ETH_P_IP ); + skb->protocol =htons (ETH_P_IPV6 ); segs =skb_gso_segment (skb,0 );kfree_skb (skb);if (unlikely (IS_ERR (segs)))
David Miller
maintainerFrom: Patrick McHardy <[email protected]>
Date: Mon, 31 Jul 2006 06:06:37 +0200
Quoted 10 lines
Quoted 7 lines · Herbert Xu
Quoted 3 lines · Patrick McHardy
[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets
Signed-off-by Patrick McHardy <[email protected]>Acked-by Herbert Xu <[email protected]>I believe you missed this one. Attached again for your convenience.
It's in my tree, but thanks for reminding me.