Skip to contentSkip to conversation

mark sk98lin driver for removal

PATCH In review Stephen Hemminger 4 participants 4 messages Jul 22, 2006 – Jul 29, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mark sk98lin driver for removal

The sk98lin driver is now superseded by the skge driver. I wanted to just let the old driver wither and die from old age, but there are still bugs that are too painful to fix.

See http://bugzilla.kernel.org/show_bug.cgi?id=6780
The board crashes repeatedly after 2 weeks. It probably is something in the vendor MIB code. That code is a mess, and starting over was one of the motivations for creating the skge driver.

So rather than add more bondo to the old beater to cover the rusty bits, throw it in the dustbin.

Documentation/feature-removal-schedule.txt +7 -0
@@ -258,3 +258,10 @@ Why:	These drivers never compiled since 
 Who:	Jean Delvare <[email protected]>
 
 ---------------------------
+
+What:   sk98lin network driver
+When:   January 2007
+Why:    replaced by the skge driver
+Who:    Stephen Hemminger <[email protected]>
+
+---------------------------
MAINTAINERS +4 -0
@@ -2677,6 +2677,10 @@ L:	[email protected]
 W:	http://mmc.drzeus.cx/wiki/Linux/Drivers/sdhci
 S:	Maintained
 
+SK98LIN GIGABBIT ETHERNET DRIVER
+L:	[email protected]
+S:	Obsolete
+
 SKGE, SKY2 10/100/1000 GIGABIT ETHERNET DRIVERS
 P:	Stephen Hemminger
 M:	[email protected]
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Stephen Hemminger

The sk98lin driver is now superseded by the skge driver. I wanted to just let the old driver wither and die from old age, but there are still bugs that are too painful to fix.

See http://bugzilla.kernel.org/show_bug.cgi?id=6780
The board crashes repeatedly after 2 weeks. It probably is something in the vendor MIB code. That code is a mess, and starting over was one of the motivations for creating the skge driver.

Quoted 4 lines

So rather than add more bondo to the old beater to cover the rusty bits, throw it in the dustbin.

After a huge number of bug reports in Fedora 'went away' when we switched our users to using skge instead, I wholeheartedly endorse this. sk98lin is a disaster. The last time I looked the vendor out-of-tree driver had a huge delta vs mainline, and backed out numerous fixes made to it in the mainline kernel. It's a huge effort to get the 'good bits' out of that patch, and letting it die is the only sensible solution IMO.

Quoted 1 line

+SK98LIN GIGABBIT ETHERNET DRIVER

typo :-)

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#2 lore raw
Quoted 8 lines · Dave Jones
Quoted 7 lines · Stephen Hemminger

The sk98lin driver is now superseded by the skge driver. I wanted to just let the old driver wither and die from old age, but there are still bugs that are too painful to fix.

So rather than add more bondo to the old beater to cover the rusty bits, throw it in the dustbin.

Quoted 6 lines
Quoted 1 line

After a huge number of bug reports in Fedora 'went away' when we switched our users to using skge instead, I wholeheartedly endorse this.

Signature · 2 lines
John W. Linville
[email protected]
#3 lore raw
In reply to Stephen Hemminger

ACK, however

[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt 1 patch(es) to process.

Applying 'mark sk98lin driver for removal'

error: patch failed: Documentation/feature-removal-schedule.txt:258
error: Documentation/feature-removal-schedule.txt: patch does not apply