: Trace which secpath state is reject factor.

PATCH In review Masahide NAKAMURA 2 participants 3 messages Jul 29, 2006 – Aug 2, 2006

Subsystems (3)

Networking Network drivers Networking IPsec

lore

Share & tools

lore

Masahide NAKAMURA

author

2006-07-29 09:30 UTC #0 lore raw

PATCH 10/23 : Trace which secpath state is reject factor.

For Mobile IPv6 usage, it is required to trace which secpath state is reject factor in order to notify it to user space (to know the address which cannot be used route optimized communication).
Based on MIPL2 kernel patch.

---
 include/net/xfrm.h     |    3 ++
 net/xfrm/xfrm_policy.c |   67 +++++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 63 insertions(+), 7 deletions(-)

include/net/xfrm.h +3 -0

index 46f8616..8dcf6cd 100644
@@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT	1
 	void			(*destructor)(struct xfrm_state *);
 	int			(*input)(struct xfrm_state *, struct sk_buff *skb);
 	int			(*output)(struct xfrm_state *, struct sk_buff *pskb);
+#ifdef CONFIG_XFRM_ADVANCED
+	int			(*reject)(struct xfrm_state *, struct sk_buff *skb, struct flowi *);
+#endif
 	int			(*place_find)(struct xfrm_state *, struct sk_buff *, u8 **);
 	xfrm_address_t		*(*local_addr)(struct xfrm_state *, xfrm_address_t *);
 	xfrm_address_t		*(*remote_addr)(struct xfrm_state *, xfrm_address_t *);

net/xfrm/xfrm_policy.c +60 -7

122 lines not on this page · raw message

Signature · 1 line

1.4.1

David Miller

maintainer

2006-08-02 00:15 UTC #1 lore raw

From: Masahide NAKAMURA <[email protected]>
Date: Sat, 29 Jul 2006 18:30:29 +0900

include/net/xfrm.h #define XFRM_TYPE_NON_FRAGMENT 1 · line 277

Quoted 7 lines

include/net/xfrm.h +3 -0

@@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT	1
 	void			(*destructor)(struct xfrm_state *);
 	int			(*input)(struct xfrm_state *, struct sk_buff *skb);
 	int			(*output)(struct xfrm_state *, struct sk_buff *pskb);
+#ifdef CONFIG_XFRM_ADVANCED
+	int			(*reject)(struct xfrm_state *, struct sk_buff *skb, struct flowi *);
+#endif

xfrm_secpath_reject() unconditionally dereferences this new reject operation pointer, but this patch contains no assignments of it.

Please send incremental patches that are fully functional all by themselves, so that if each one is applied, it would compile and work.

Masahide NAKAMURA

author

2006-08-02 06:07 UTC #2 lore raw

Re: (usagi-core 30280) Re: [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor.

Quoted 14 lines · David Miller

From: Masahide NAKAMURA <[email protected]>
Date: Sat, 29 Jul 2006 18:30:29 +0900
include/net/xfrm.h #define XFRM_TYPE_NON_FRAGMENT 1 · line 277
Quoted 7 lines
include/net/xfrm.h +3 -0
@@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT	1
 	void			(*destructor)(struct xfrm_state *);
 	int			(*input)(struct xfrm_state *, struct sk_buff *skb);
 	int			(*output)(struct xfrm_state *, struct sk_buff *pskb);
+#ifdef CONFIG_XFRM_ADVANCED
+	int			(*reject)(struct xfrm_state *, struct sk_buff *skb, struct flowi *);
+#endif
xfrm_secpath_reject() unconditionally dereferences this new reject operation pointer, but this patch contains no assignments of it.

Quoted 3 lines

Please send incremental patches that are fully functional all by themselves, so that if each one is applied, it would compile and work.

Thanks, I'll send so next time.

Signature · 1 line

Masahide NAKAMURA