Skip to contentSkip to conversation

include/asm-frv/*.h: printk("SOMETEXT"....) ->

PATCH New Alexander Bodnarashik 1 participant 2 messages Aug 8, 2006 – Aug 16, 2006 Kernel janitors

lore
Share & tools
lore

Alexander Bodnarashik

author
#0 lore raw

PATCH 1/1 include/asm-frv/*.h: printk("SOMETEXT"....) ->

I've tried to cleanup some code inside "include/asm-frv" folder. Hope i understand the meaning of KERN_* constants correctly.

Signed-off-by Alexander Bodnarashik <[email protected]>
include/asm-frv/math-emu.h +2 -2
index 0c8f731..c450309 100644
@@ -117,9 +117,9 @@ extern unsigned int fp_debugprint;
 	static int __count = 3;				\
 							\
 	if (__count > 0) {				\
-		printk("You just hit an unimplemented "	\
+		printk(KERN_WARNING "You just hit an unimplemented "	\
 		       "fpu instruction (%s)\n", str);	\
-		printk("Please report this to ....\n");	\
+		printk(KERN_WARNING "Please report this to ....\n");	\
 		__count--;				\
 	}						\
 })
include/asm-frv/pgtable.h +4 -4
index 7af7485..ff341a3 100644
@@ -156,13 +156,13 @@ extern unsigned long empty_zero_page;
 extern pgd_t swapper_pg_dir[PTRS_PER_PGD];
 
 #define pte_ERROR(e) \
-	printk("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
+	printk(KERN_ERR "%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
 #define pmd_ERROR(e) \
-	printk("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
+	printk(KERN_ERR "%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
 #define pud_ERROR(e) \
-	printk("%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
+	printk(KERN_ERR "%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
 #define pgd_ERROR(e) \
-	printk("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
+	printk(KERN_ERR "%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
 
 /*
  * Certain architectures need to do special things when PTEs

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#1 lore raw

PATCH 1/1 include/asm-frv/*.h: printk("SOMETEXT"....) ->

I've tried to cleanup some code inside "include/asm-frv" folder. Hope i understand the meaning of KERN_* constants correctly. Patch is resent, because previous attempt was silently ignore. I think it's because i've used attachment. Hope now it mets all requirements.

Signed-off-by Alexander Bodnarashik <[email protected]>

---

include/asm-frv/math-emu.h +0 -0
index 0c8f731..c450309 100644
@@ -117,9 +117,9 @@ extern unsigned int fp_debugprint;

	static int __count = 3;				\
							\
	if (__count > 0) {				\
-		printk("You just hit an unimplemented "	\
+		printk(KERN_WARNING "You just hit an unimplemented "	\
		       "fpu instruction (%s)\n", str);	\
-		printk("Please report this to ....\n");	\
+		printk(KERN_WARNING "Please report this to ....\n");	\
		__count--;				\
	}						\
})
include/asm-frv/pgtable.h +0 -0
index 7af7485..ff341a3 100644
@@ -156,13 +156,13 @@ extern unsigned long empty_zero_page;

extern pgd_t swapper_pg_dir[PTRS_PER_PGD];

#define pte_ERROR(e) \
- printk("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
+ printk(KERN_ERR "%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
#define pmd_ERROR(e) \
- printk("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
+ printk(KERN_ERR "%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
#define pud_ERROR(e) \
- printk("%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
+ printk(KERN_ERR "%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
#define pgd_ERROR(e) \
- printk("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
+ printk(KERN_ERR "%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))

/*
* Certain architectures need to do special things when PTEs

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors