Skip to contentSkip to conversation

ahci: remove IRQ mask clearing from init_controller()

PATCH Applied Tejun Heo 2 participants 4 messages Aug 7, 2006 – Aug 9, 2006

Subsystems (2)
SCSI libata
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 ahci: remove IRQ mask clearing from init_controller()

Initial IRQ mask clearing is done by libata-core by freezing all ports prior to requesting IRQ. Remove redundant IRQ clearing from init_controller().

Signed-off-by Tejun Heo <[email protected]>

---

 drivers/scsi/ahci.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

049892ed973dc00569e26130826fef0000fc7577

drivers/scsi/ahci.c +1 -2
index f5734a9..68fd766 100644
@@ -662,14 +662,13 @@ #endif
 		VPRINTK("PORT_SCR_ERR 0x%x\n", tmp);
 		writel(tmp, port_mmio + PORT_SCR_ERR);
 
-		/* clear & turn off port IRQ */
+		/* clear port IRQ */
 		tmp = readl(port_mmio + PORT_IRQ_STAT);
 		VPRINTK("PORT_IRQ_STAT 0x%x\n", tmp);
 		if (tmp)
 			writel(tmp, port_mmio + PORT_IRQ_STAT);
 
 		writel(1 << i, mmio + HOST_IRQ_STAT);
-		writel(0, port_mmio + PORT_IRQ_MASK);
 	}
 
 	tmp = readl(mmio + HOST_CTL);
Signature · 1 line
1.3.2
#1 lore raw
Quoted 5 lines · Tejun Heo

Initial IRQ mask clearing is done by libata-core by freezing all ports prior to requesting IRQ. Remove redundant IRQ clearing from init_controller().

Signed-off-by Tejun Heo <[email protected]>

is this for upstream (2.6.19) or upstream-fixes (2.6.18-rc)?

Jeff

author
#2 lore raw
Quoted 8 lines · Jeff Garzik
Quoted 5 lines · Tejun Heo

Initial IRQ mask clearing is done by libata-core by freezing all ports prior to requesting IRQ. Remove redundant IRQ clearing from init_controller().

Signed-off-by Tejun Heo <[email protected]>

is this for upstream (2.6.19) or upstream-fixes (2.6.18-rc)?

It's for #upstream.

Signature · 1 line
tejun