ehea: PPC - New hcall opcode defines
PATCH 1/1 ehea: PPC - New hcall opcode defines
Hi,
this patch adds additional hcall opcode defines in asm-powerpc/hvcall.h which are required for the IBM eHEA Ethernet Device Driver which is targeted for kernel inclusion in the near future.
Including those defines in hvcall.h was a request we got in reply to posting our driver.
Driver post: http://ozlabs.org/pipermail/linuxppc-dev/2006-August/024947.html
Reply: http://ozlabs.org/pipermail/linuxppc-dev/2006-August/024971.html
I'm aware this does not fix a bug and we're already at rc4 but since it adds only a few innocent defines it would be great if it could be included in 2.6.18-rc5.
Kind regards
Thomas
include/asm-powerpc/hvcall.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)
include/asm-powerpc/hvcall.h +13 -0
@@ -201,6 +201,19 @@#define H_JOIN 0x298#define H_VASI_STATE 0x2A4#define H_ENABLE_CRQ 0x2B0 +#define H_ALLOC_HEA_RESOURCE 0x278 +#define H_MODIFY_HEA_QP 0x250 +#define H_QUERY_HEA_QP 0x254 +#define H_QUERY_HEA 0x258 +#define H_QUERY_HEA_PORT 0x25C +#define H_MODIFY_HEA_PORT 0x260 +#define H_REG_BCMC 0x264 +#define H_DEREG_BCMC 0x268 +#define H_REGISTER_HEA_RPAGES 0x26C +#define H_DISABLE_AND_GET_HEA 0x270 +#define H_GET_HEA_INFO 0x274 +#define H_ADD_CONN 0x284 +#define H_DEL_CONN 0x288#ifndef __ASSEMBLY__
Quoted 11 lines · On Thu, 10 Aug 2006 17:05:28 +0200 Thomas Klein <[email protected]> wrote:
diff -Nurp -X dontdiff
linux-2.6.18-rc4/include/asm-powerpc/hvcall.hpatched_kernel/include/asm-powerpc/hvcall.hinclude/asm-powerpc/hvcall.h +3
-0@@ -201,6 +201,19 @@#define H_JOIN 0x298#define H_VASI_STATE 0x2A4#define H_ENABLE_CRQ 0x2B0 +#define H_ALLOC_HEA_RESOURCE 0x278 +#define H_MODIFY_HEA_QP 0x250 +#define H_QUERY_HEA_QP 0x254
include/asm-powerpc/hvcall.h line 216
Quoted 10 lines
include/asm-powerpc/hvcall.h +10
-0+#define H_QUERY_HEA 0x258 +#define H_QUERY_HEA_PORT 0x25C +#define H_MODIFY_HEA_PORT 0x260 +#define H_REG_BCMC 0x264 +#define H_DEREG_BCMC 0x268 +#define H_REGISTER_HEA_RPAGES 0x26C +#define H_DISABLE_AND_GET_HEA 0x270 +#define H_GET_HEA_INFO 0x274 +#define H_ADD_CONN 0x284 +#define H_DEL_CONN 0x288
This patch appears to be whitespace damaged and it would be preferable if the new defines were in there correct places in numerical order.
Thanks.
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Quoted 27 lines · Stephen Rothwell
Quoted 11 lines · On Thu, 10 Aug 2006 17:05:28 +0200 Thomas Klein <[email protected]> wrote:
diff -Nurp -X dontdiff
linux-2.6.18-rc4/include/asm-powerpc/hvcall.hpatched_kernel/include/asm-powerpc/hvcall.hinclude/asm-powerpc/hvcall.h +4
-0@@ -201,6 +201,19 @@#define H_JOIN 0x298#define H_VASI_STATE 0x2A4#define H_ENABLE_CRQ 0x2B0 +#define H_ALLOC_HEA_RESOURCE 0x278 +#define H_MODIFY_HEA_QP 0x250 +#define H_QUERY_HEA_QP 0x254 +#define H_QUERY_HEA 0x258include/asm-powerpc/hvcall.h line 217
Quoted 10 lines
include/asm-powerpc/hvcall.h +9
-0+#define H_QUERY_HEA_PORT 0x25C +#define H_MODIFY_HEA_PORT 0x260 +#define H_REG_BCMC 0x264 +#define H_DEREG_BCMC 0x268 +#define H_REGISTER_HEA_RPAGES 0x26C +#define H_DISABLE_AND_GET_HEA 0x270 +#define H_GET_HEA_INFO 0x274 +#define H_ADD_CONN 0x284 +#define H_DEL_CONN 0x288This patch appears to be whitespace damaged and it would be preferable if the new defines were in there correct places in numerical order.
Quoted 3 lines
Thanks.
I agree. I posted a new patch (http://ozlabs.org/pipermail/linuxppc-dev/2006-August/025032.html)
where I rearranged the defines to fit in the numerical order with the other defines.
The whitespaces are not damaged although they appear to be. This is due to the usage of TAB characters to align the hex values. TAB characters are used in the whole file to align the numerical values. I applied the patch and the result looks okay.