Skip to contentSkip to conversation

LG K1 Express Laptop

PATCH In review Magnus Sandin 2 participants 4 messages Aug 14, 2006 – Aug 16, 2006 2 messages not in the archive

lore
Share & tools
lore

Magnus Sandin

author
#0 lore raw

PATCH 1/1 LG K1 Express Laptop

The attached patch will unset the S/PDIF-in bit (on LG K1 Express Laptops only) in the vendor specific register 0x7A of the Realtek ALC655 chip.

Without this patch, there where no sound on the LG K1 Express model:
K1-2333V laptop at all.

Regards
// Magnus Sandin

pci/ac97/ac97_patch.c 2006-08-14 23:20:32.000000000 +0200 renamed from pci/ac97/ac97_patch.c 2006-08-14 22:13:17.000000000 +0200 +3 -0
diff -Nru alsa-kernel/pci/ac97/ac97_patch.c alsa-kernel-patched/pci/ac97/ac97_patch.c
@@ -2210,6 +2210,9 @@
                if (ac97->subsystem_vendor == 0x1462 &&
                    ac97->subsystem_device == 0x0131) /* MSI S270 laptop */
                        val &= ~(1 << 1); /* Pin 47 is EAPD (for internal speaker) */
+               else if (ac97->subsystem_vendor == 0x1462 &&
+                        ac97->subsystem_device == 0x0161) /* LG K1 Express Laptop */
+                       val &= ~(1 << 1); /* Pin 47 is EAPD (for internal speaker) */
                else
                        val |= (1 << 1); /* Pin 47 is spdif input pin */
        }

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

At Mon, 14 Aug 2006 23:44:55 +0200,

Quoted 16 lines · Magnus Sandin

The attached patch will unset the S/PDIF-in bit (on LG K1 Express Laptops only) in the vendor specific register 0x7A of the Realtek ALC655 chip.

Without this patch, there where no sound on the LG K1 Express model:
K1-2333V laptop at all.

Regards
// Magnus Sandin

[2 alsa-lg_k1_express.patch <text/x-patch (7bit)>]
diff -Nru alsa-kernel/pci/ac97/ac97_patch.c alsa-kernel-patched/pci/ac97/ac97_patch.c

pci/ac97/ac97_patch.c 2006-08-14 23:20:32.000000000 +0200 line 2218

Quoted 9 lines
pci/ac97/ac97_patch.c 2006-08-14 23:20:32.000000000 +0200 renamed from pci/ac97/ac97_patch.c 2006-08-14 22:13:17.000000000 +0200 +3 -0
@@ -2210,6 +2210,9 @@
                if (ac97->subsystem_vendor == 0x1462 &&
                    ac97->subsystem_device == 0x0131) /* MSI S270 laptop */
                        val &= ~(1 << 1); /* Pin 47 is EAPD (for internal speaker) */
+               else if (ac97->subsystem_vendor == 0x1462 &&
+                        ac97->subsystem_device == 0x0161) /* LG K1 Express Laptop */
+                       val &= ~(1 << 1); /* Pin 47 is EAPD (for internal speaker) */
                else
                        val |= (1 << 1); /* Pin 47 is spdif input pin */
        }

I prefer putting it to a single if block.
Could you rewrite the patch and give a proper signed-off-by?

thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

At Wed, 16 Aug 2006 14:50:24 +0200,

Quoted 5 lines · Magnus Sandin

Here is the patch for the LG K1 Express (K1-2333V) laptop that enables sound output.

Signed-off-by Magnus Sandin <[email protected]>

Hm, your mailer seems to break the inlined patch.
Please post with an attachment again.

thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

At Wed, 16 Aug 2006 15:17:58 +0200,

Quoted 5 lines · Magnus Sandin

Attached is the patch for the LG K1 Express (K1-2333V) laptop that enables sound output.

Hope this post works :-)

Well, didn't work :)
Tabs were wrongly converted to the white spaces in your patch. So, possibly it wasn't a fault of your mailer.

Anyway, don't worry, I applied it manually to HG tree.

Thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642