xenbus cleanup
PATCH 1/6 xenbus cleanup
Hi,
The patch below has some xenbus cleanups. Changes:
* move function prototypes to the top of the file.
* uses the "struct bus_type" function pointers instead of overwriting the "struct device_driver" ones for xenbus_dev_probe() and xenbus_dev_remove().
please apply,
Gerd
Signature · 2 lines
Gerd Hoffmann <[email protected]> http://www.suse.de/~kraxel/julika-dora.jpeg
Signed-off-by Gerd Hoffmann <[email protected]>
drivers/xen/xenbus/xenbus_probe.c +17 -11
@@ -60,6 +60,14 @@ static struct notifier_block *xenstore_cstatic void wait_for_devices (struct xenbus_driver *xendrv); +static int xenbus_probe_frontend (const char *type,const char *name); +static int xenbus_uevent_backend (struct device *dev,char **envp, +int num_envp,char *buffer,int buffer_size); +static int xenbus_probe_backend (const char *type,const char *domid); + +static int xenbus_dev_probe (struct device *_dev); +static int xenbus_dev_remove (struct device *_dev); +/* If something in array of ids matches this device, return it. */ static const struct xenbus_device_id *match_device (const struct xenbus_device_id *arr,struct xenbus_device *dev)
@@ -168,15 +176,16 @@ static int read_frontend_details(struct/* Bus type for frontend drivers. */ -static int xenbus_probe_frontend (const char *type,const char *name);static struct xen_bus_type xenbus_frontend = { .root ="device" , .levels =2 ,/* device/type/<id> */ .get_bus_id = frontend_bus_id, .probe = xenbus_probe_frontend, .bus = { - .name ="xen" , - .match = xenbus_match, + .name ="xen" , + .match = xenbus_match, + .probe = xenbus_dev_probe, + .remove = xenbus_dev_remove, }, .dev = { .bus_id ="xen" ,
@@ -221,18 +230,17 @@ static int backend_bus_id(char bus_id[BUreturn 0 ; } -static int xenbus_uevent_backend (struct device *dev,char **envp, -int num_envp,char *buffer,int buffer_size); -static int xenbus_probe_backend (const char *type,const char *domid);static struct xen_bus_type xenbus_backend = { .root ="backend" , .levels =3 ,/* backend/type/<frontend>/<id> */ .get_bus_id = backend_bus_id, .probe = xenbus_probe_backend, .bus = { - .name ="xen-backend" , - .match = xenbus_match, - .uevent = xenbus_uevent_backend, + .name ="xen-backend" , + .match = xenbus_match, + .probe = xenbus_dev_probe, + .remove = xenbus_dev_remove, + .uevent = xenbus_uevent_backend, }, .dev = { .bus_id ="xen-backend" ,
@@ -399,8 +407,6 @@ static int xenbus_register_driver_common drv->driver.name = drv->name; drv->driver.bus = &bus->bus; drv->driver.owner = drv->owner; - drv->driver.probe = xenbus_dev_probe; - drv->driver.remove = xenbus_dev_remove;mutex_lock (&xenwatch_mutex); ret =driver_register (&drv->driver);
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel