Skip to contentSkip to conversation

fix segfault in docproc.c

PATCH In review Henne 2 participants 2 messages Aug 21, 2006 Kbuild

lore
Share & tools
lore

Henne

author
#0 lore raw

PATCH 1/1 fix segfault in docproc.c

From: Henrik Kretzschmar <[email protected]>

Adds a missing exit, if the file that should be parsed couldn't be opened.
Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened. This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs.

Signed-off-by Henrik Kretzschmar <[email protected]>

---

scripts/basic/docproc.c +1 -0
@@ -177,6 +177,7 @@
 		{
 			fprintf(stderr, "docproc: ");
 			perror(real_filename);
+			exit(1);
 		}
 		while(fgets(line, MAXLINESZ, fp)) {
 			char *p;
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · On Mon, 21 Aug 2006 20:34:29 +0200 Henne wrote:

From: Henrik Kretzschmar <[email protected]>

Adds a missing exit, if the file that should be parsed couldn't be opened.
Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened. This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs.

Signed-off-by Henrik Kretzschmar <[email protected]>

Thanks.

Acked-by Randy Dunlap <[email protected]>

Could you also update Documentation/DocBook/libata.tmpl to use drivers/ata/ instead of drivers/scsi/ on the !I and !E lines?

Quoted 15 lines

---

scripts/basic/docproc.c +1 -1
@@ -177,6 +177,7 @@
 		{
 			fprintf(stderr, "docproc: ");
 			perror(real_filename);
+			exit(1);
 		}
 		while(fgets(line, MAXLINESZ, fp)) {
 			char *p;
 
 
-
Quoted 5 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

---
~Randy