Skip to contentSkip to conversation

bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence]

PATCH New Larry Finger 1 participant 1 message Aug 23, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence]

John,

This is a better solution of the issue. Please disregard the patch sent yesterday.

Larry

-------------------------------

When bcm43xx-softmac is given an ifdown/ifup sequence, the value for bcm->mac_suspended ends up wrong, which leads to a large number of assert(bcm->mac_suspended>=0) messages. This one-line patch fixes this problem.

I think the following is the correct fix for the issue.
It is already in the d80211 branch. (Seems like it got lost somehow).

drivers/net/wireless/bcm43xx/bcm43xx_main.c +2 -0
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
@@ -3349,6 +3349,8 @@
 	memset(bcm->dma_reason, 0, sizeof(bcm->dma_reason));
 	bcm->irq_savedstate = BCM43xx_IRQ_INITIAL;
 
+	bcm->mac_suspended = 1;
+
 	/* Noise calculation context */
 	memset(&bcm->noisecalc, 0, sizeof(bcm->noisecalc));
 
Signature · 1 line
Greetings Michael.