ipw2200: small cleanups
Remove dead, commented-out code, and switch to C-style commments.
drivers/net/wireless/ipw2200.c +4 -25
@@ -2667,7 +2667,7 @@ static void ipw_fw_dma_abort(struct ipw_IPW_DEBUG_FW (">> :\n" ); -//set the Stop and Abort bit +/* set the Stop and Abort bit */ control =DMA_CONTROL_SMALL_CB_CONST_VALUE |DMA_CB_STOP_AND_ABORT ;ipw_write_reg32 (priv,IPW_DMA_I_DMA_CONTROL , control); priv->sram_desc.last_cb_index =0 ;
@@ -3002,8 +3002,6 @@ static int ipw_load_ucode(struct ipw_priif (rc <0 )return rc; -// spin_lock_irqsave(&priv->lock, flags); -for (addr =IPW_SHARED_LOWER_BOUND ; addr <IPW_REGISTER_DOMAIN1_END ; addr +=4 ) {ipw_write32 (priv, addr,0 );
@@ -3097,8 +3095,6 @@ static int ipw_load_ucode(struct ipw_prifirmware have problem getting alive resp. */ ipw_write_reg8 (priv,IPW_BASEBAND_CONTROL_STATUS ,0 ); -// spin_unlock_irqrestore(&priv->lock, flags); -return rc; }
@@ -6387,13 +6383,6 @@ static int ipw_wx_set_genie(struct net_d (wrqu->data.length && extra == NULL))return -EINVAL ; -//mutex_lock(&priv->mutex); - -//if (!ieee->wpa_enabled) { -// err = -EOPNOTSUPP; -// goto out; -//} -if (wrqu->data.length) { buf =kmalloc (wrqu->data.length,GFP_KERNEL );if (buf ==NULL ) {
@@ -6413,7 +6402,6 @@ static int ipw_wx_set_genie(struct net_dipw_wpa_assoc_frame (priv, ieee->wpa_ie, ieee->wpa_ie_len); out: -//mutex_unlock(&priv->mutex); return err; }
@@ -6426,13 +6414,6 @@ static int ipw_wx_get_genie(struct net_dstruct ieee80211_device *ieee = priv->ieee;int err =0 ; -//mutex_lock(&priv->mutex); - -//if (!ieee->wpa_enabled) { -// err = -EOPNOTSUPP; -// goto out; -//} -if (ieee->wpa_ie_len ==0 || ieee->wpa_ie ==NULL ) { wrqu->data.length =0 ; goto out;
@@ -6447,7 +6428,6 @@ static int ipw_wx_get_genie(struct net_dmemcpy (extra, ieee->wpa_ie, ieee->wpa_ie_len); out: -//mutex_unlock(&priv->mutex); return err; }
@@ -6558,7 +6538,6 @@ static int ipw_wx_set_auth(struct net_de ieee->ieee802_1x = param->value;break ; -//case IW_AUTH_ROAMING_CONTROL: case IW_AUTH_PRIVACY_INVOKED : ieee->privacy_invoked = param->value;break ;
@@ -6680,7 +6659,7 @@ static int ipw_wx_set_mlme(struct net_deswitch (mlme->cmd) {case IW_MLME_DEAUTH : -// silently ignore +/* silently ignore */ break ;case IW_MLME_DISASSOC :
@@ -9766,7 +9745,7 @@ static int ipw_wx_set_monitor(struct netreturn 0 ; } -#endif // CONFIG_IPW2200_MONITOR +#endif /* CONFIG_IPW2200_MONITOR */ static int ipw_wx_reset(struct net_device *dev, struct iw_request_info *info,
@@ -10009,7 +9988,7 @@ static void init_sys_config(struct ipw_ sys_config->dot11g_auto_detection =0 ; sys_config->enable_cts_to_self =0 ; sys_config->bt_coexist_collision_thr =0 ; - sys_config->pass_noise_stats_to_host =1 ;//1 -- fix for 256 + sys_config->pass_noise_stats_to_host =1 ;/* 1 -- fix for 256 */ sys_config->silence_threshold =0x1e ; }
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 2 lines
Remove dead, commented-out code, and switch to C-style commments.
Why can't we use C99 comments? We're already depending on so many GCC features that C-C99 is really nitpicky.
drivers/net/wireless/ipw2200.c static void ipw_fw_dma_abort(struct ipw_ · line 2670
Quoted 2 lines
drivers/net/wireless/ipw2200.c +1
-1-//set the Stop and Abort bit +/* set the Stop and Abort bit */
Jan Engelhardt
Quoted 5 lines · Jan Engelhardt
Quoted 2 lines
Remove dead, commented-out code, and switch to C-style commments.
Why can't we use C99 comments? We're already depending on so many GCC features that C-C99 is really nitpicky.
They look ugly to my eyes...
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 7 lines · Pavel Machek
Quoted 2 lines · Jan Engelhardt
Quoted 1 line
Remove dead, commented-out code, and switch to C-style commments.
Why can't we use C99 comments? We're already depending on so many GCC features that C-C99 is really nitpicky.
They look ugly to my eyes...
Pavel
And you can't forget to close them...