RTCAN bug fix
PATCH 1/1 RTCAN bug fix
Hello,
attached is a patch changing:
* ksrc/drivers/can/rtcan_dev.c (rtcan_dev_register): Bug fixed when maximum number of devices is exeeded.
BTW, a similar bug is present in RTnet as well.
Wolfgang.
+ diff -u xenomai/ChangeLog-ENOMEM xenomai/ChangeLog
ChangeLog renamed from ChangeLog-ENOMEM +5 -0
@@ -1,3 +1,8 @@ +2006-09-03 Wolfgang Grandegger <[email protected]> + + * ksrc/drivers/can/rtcan_dev.c (rtcan_dev_register): Bug fixed + when maximum number of devices is exeeded. + 2006-08-31 Gilles Chanteperdrix <[email protected]> * include/asm-generic/system.h (__xnlock_get): Simplify spinlocks
+ diff -u xenomai/ksrc/drivers/can/rtcan_dev.c-ENOMEM xenomai/ksrc/drivers/can/rtcan_dev.c
ksrc/drivers/can/rtcan_dev.c renamed from ksrc/drivers/can/rtcan_dev.c-ENOMEM +6 -2
@@ -223,13 +223,17 @@int rtcan_dev_register (struct rtcan_device *dev) {rtdm_lockctx_t context; - +int ret;down (&rtcan_devices_nrt_lock);rtcan_global_init (); - dev->ifindex =__rtcan_dev_new_index (); +if ((ret =__rtcan_dev_new_index ()) <0 ) { +up (&rtcan_devices_nrt_lock); +return ret; + } + dev->ifindex = ret;if (strchr (dev->name,'%' ) !=NULL )rtcan_dev_alloc_name (dev, dev->name);
Jan Kiszka
AppliedQuoted 6 lines · Wolfgang Grandegger
Hello,
attached is a patch changing:
*
ksrc/drivers/can/rtcan_dev.c(rtcan_dev_register): Bug fixed when maximum number of devices is exeeded.
Applied.
Quoted 2 lines
BTW, a similar bug is present in RTnet as well.
Yep, fixed there as well. Thanks.
All pending CAN patches are now in SVN.
Jan