Skip to contentSkip to conversation

New idea for TODO

KJ Henne 2 participants 3 messages Sep 5, 2006 Kernel janitors

lore
Share & tools
lore

Henne

author
#0 lore raw

Hi there,

I know that the TODO list is long, but I may have found a new task.

In drivers/scsi lies a file called scsi.h which seems to be a relict and is included in many mature scsi-drivers, but include/scsi/scsi.h would be the better choice.
After a little surfing I think all typedef'd Scsi_Cmnd can be replaced with struct scsi_cmnd, to get rid of that typedef stuff.

Correct me if I'm wrong.

Greets,
Henne

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 10 lines · Henne

Hi there,

I know that the TODO list is long, but I may have found a new task.

In drivers/scsi lies a file called scsi.h which seems to be a relict and is included in many mature scsi-drivers, but include/scsi/scsi.h would be the better choice.
After a little surfing I think all typedef'd Scsi_Cmnd can be replaced with struct scsi_cmnd, to get rid of that typedef stuff.

Correct me if I'm wrong.

include/scsi/scsi.h says:

/*
* NOTE: this file only contains compatibility glue for old drivers. All
* these wrappers will be removed sooner or later. For new code please use
* the interfaces declared in the headers in include/scsi/
*/

The file is already nearly empty, and the goal is getting it completely empty, not moving the remaining stuff to a different header.

Quoted 2 lines

Greets,
Henne

cu
Adrian

Signature · 9 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
author
#2 lore raw
In reply to Henne
Quoted 11 lines
Quoted 8 lines

I know that the TODO list is long, but I may have found a new task.

In drivers/scsi lies a file called scsi.h which seems to be a relict and is included in many mature scsi-drivers, but include/scsi/scsi.h would be the better choice.
After a little surfing I think all typedef'd Scsi_Cmnd can be replaced with struct scsi_cmnd, to get rid of that typedef stuff.

Correct me if I'm wrong.

include/scsi/scsi.h says:

Quoted 8 lines

/*
* NOTE: this file only contains compatibility glue for old drivers. All
* these wrappers will be removed sooner or later. For new code please use
* the interfaces declared in the headers in include/scsi/
*/

The file is already nearly empty, and the goal is getting it completely empty, not moving the remaining stuff to a different header.

Thats what I meant, but I think I don't wrote it, right? I wanted to say:
- change Scsi_Cmnd to struct scsi_cmnd in all drivers
- delete the include "scsi_typedefs.h" from drivers/scsi.h and
- remove drivers/scsi_typedefs.h from the tree

Don't ask me why I didn't wrote it in my first mail. :)

Greets,
Henne
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors