Skip to contentSkip to conversation

powerpc/64s: Include <asm/nmi.h> header file to fix a warning

PATCH Applied Mathieu Malaterre 3 participants 3 messages Mar 12, 2019 – Mar 14, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/64s: Include <asm/nmi.h> header file to fix a warning

Make sure to include <asm/nmi.h> to provide the following prototype:
hv_nmi_check_nonrecoverable.

Remove the following warning treated as error (W=1):

arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]

---
 arch/powerpc/kernel/traps.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/traps.c +1 -0
index a21200c6aaea..1fd45a8650e1 100644
@@ -71,6 +71,7 @@
 #include <sysdev/fsl_pci.h>
 #include <asm/kprobes.h>
 #include <asm/stacktrace.h>
+#include <asm/nmi.h>
 
 #if defined(CONFIG_DEBUGGER) || defined(CONFIG_KEXEC_CORE)
 int (*__debugger)(struct pt_regs *regs) __read_mostly;
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Le 12/03/2019 à 21:18, Mathieu Malaterre a écrit :

Quoted 8 lines

Make sure to include <asm/nmi.h> to provide the following prototype:
hv_nmi_check_nonrecoverable.

Remove the following warning treated as error (W=1):

arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]

Quoted 17 lines
---
  arch/powerpc/kernel/traps.c | 1 +
  1 file changed, 1 insertion(+)
arch/powerpc/kernel/traps.c +1 -0
index a21200c6aaea..1fd45a8650e1 100644
@@ -71,6 +71,7 @@
  #include <sysdev/fsl_pci.h>
  #include <asm/kprobes.h>
  #include <asm/stacktrace.h>
+#include <asm/nmi.h>
 
  #if defined(CONFIG_DEBUGGER) || defined(CONFIG_KEXEC_CORE)
  int (*__debugger)(struct pt_regs *regs) __read_mostly;
#2 lore raw
In reply to Mathieu Malaterre
Quoted 9 lines · Mathieu Malaterre

Make sure to include <asm/nmi.h> to provide the following prototype:
hv_nmi_check_nonrecoverable.

Remove the following warning treated as error (W=1):

arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/de3c83c2fd2b87cf68214eda76dfa669

cheers