mm: book3s32: add require space around that '?' and ':'
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 mm: book3s32: add require space around that '?' and ':'
Fix below checkpatch errors:
./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that '?' (ctx:VxW) ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that ':' (ctx:VxW)
--- arch/powerpc/mm/book3s32/tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/mm/book3s32/tlb.c +1 -1
@@ -99,7 +99,7 @@ void hash__flush_tlb_page(struct vm_area_struct *vma, unsigned long vmaddr)struct mm_struct *mm;pmd_t *pmd; - mm = (vmaddr <TASK_SIZE )? vma->vm_mm: &init_mm; + mm = (vmaddr <TASK_SIZE ) ? vma->vm_mm : &init_mm; pmd =pmd_off (mm, vmaddr);if (!pmd_none (*pmd))flush_hash_pages (mm->context.id, vmaddr,pmd_val (*pmd),1 );
Hello,
Le 20/07/2023 à 09:34, [email protected] a écrit :
Quoted 6 lines
Fix below checkpatch errors:
./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that '?' (ctx:VxW)./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that ':' (ctx:VxW)
Can you please explain the purpose of those changes ? Do you use some tools that get disturbed by such cosmetic errors ? Otherwise what is your reason ?
We don't accept such standelone minor cosmetic changes at the first place because it looks like a waste of time.
If you have major reasons to want those changes, please re-submit with a details explanation in the commit message.
Thanks
Christophe
Quoted 21 lines
Signed-off-by Yu Han <[email protected]>--- arch/powerpc/mm/book3s32/tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/mm/book3s32/tlb.c +1
-1@@ -99,7 +99,7 @@ void hash__flush_tlb_page(struct vm_area_struct *vma, unsigned long vmaddr) struct mm_struct *mm; pmd_t *pmd; - mm = (vmaddr < TASK_SIZE)? vma->vm_mm: &init_mm; + mm = (vmaddr < TASK_SIZE) ? vma->vm_mm : &init_mm; pmd = pmd_off(mm, vmaddr); if (!pmd_none(*pmd))
flush_hash_pages(mm->context.id, vmaddr, pmd_val(*pmd), 1);