Skip to contentSkip to conversation

mtd: spi-nor: Add gd25lx128j chip

PATCH Superseded Flaviu Nistor 2 participants 3 messages Feb 25 – Mar 8 Memory technology devices (MTD)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: Add gd25lx128j chip

Add gd25lx128j GIGADEVICE chip to spi-nor id table.

---
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -0
index 3bcb0d7b7ba..b79cbcb2858 100644
@@ -202,6 +202,8 @@ const struct flash_info spi_nor_ids[] = {
 	SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
 	{INFO("gd55lt02g", 0xc8661C, 0, 64 * 1024, 4096,	SECT_4K |
 	SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
+	{INFO("gd25lx128j", 0xc86818, 0, 64 * 1024, 256,	SECT_4K |
+	SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES)},
 	{
 		INFO("gd25lx256e", 0xc86819, 0, 64 * 1024, 512,
 		     SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES)
Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 12 lines

Add gd25lx128j GIGADEVICE chip to spi-nor id table.

---
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 3bcb0d7b7ba..b79cbcb2858 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 206

Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +2 -0
@@ -202,6 +202,8 @@ const struct flash_info spi_nor_ids[] = {
        SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
        {INFO("gd55lt02g", 0xc8661C, 0, 64 * 1024, 4096,        SECT_4K |
        SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
+       {INFO("gd25lx128j", 0xc86818, 0, 64 * 1024, 256,        SECT_4K |
+       SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES)},

This device is 128Mb (16MB) that doesn't require 4-byte addressing. Is 'SPI_NOR_4B_OPCODES' really needed?

Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +0 -1
        {
                INFO("gd25lx256e", 0xc86819, 0, 64 * 1024, 512,
                     SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES)
--

2.43.0

Thanks,
Takahiro

#2 lore raw

Hi Takahiro,

Quoted 11 lines

Hi,

drivers/mtd/spi/spi-nor-ids.=

Quoted 8 lines

Add gd25lx128j GIGADEVICE chip to spi-nor id table. =20

---
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)

=20

drivers/mtd/spi/spi-nor-ids.= renamed from drivers/mtd/spi/spi-nor-ids.c +0 -0

c

Quoted 13 lines

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] =3D { · line 206

Quoted 9 lines

index 3bcb0d7b7ba..b79cbcb2858 100644

drivers/mtd/spi/spi-nor-ids.c +2 -0
@@ -202,6 +202,8 @@ const struct flash_info spi_nor_ids[] =3D {
        SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
        {INFO("gd55lt02g", 0xc8661C, 0, 64 * 1024, 4096,        SECT_4K |
        SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)},
+       {INFO("gd25lx128j", 0xc86818, 0, 64 * 1024, 256,        SECT_4K |
+       SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES)},

This device is 128Mb (16MB) that doesn't require 4-byte addressing. Is 'SPI_NOR_4B_OPCODES' really needed?

SPI_NOR_4B_OPCODES is supported and it works but indeed it is not mandatory. Thanks for pointing this out. I will send a v2.

Quoted 8 lines
Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +0 -1
        {
                INFO("gd25lx256e", 0xc86819, 0, 64 * 1024, 512,
                     SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES)
--

2.43.0

Thanks,
Takahiro