Skip to contentSkip to conversation

OMAP3 Touchbook: Fix MMC caps

PATCH In review Radek (Mrkva) Pilař 2 participants 3 messages Feb 24, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 OMAP3 Touchbook: Fix MMC caps

MMC controller cannot handle MMC_CAP_4_BIT_DATA nor MMC_CAP_8_BIT_DATA - the card won't be detected (tested with two SDHC cards, both Class6). Thus disabling.

---
arch/arm/mach-omap2/board-omap3touchbook.c | 1 -

1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3touchbook.c +0 -0
index 6a60f79..e65a32d 100644
@@ -109,7 +109,6 @@ static struct omap_nand_platform_data omap3touchbook_nand_data = {
static struct omap2_hsmmc_info mmc[] = {
	{
		.mmc		= 1,
-		.caps		= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
		.gpio_wp	= 29,
	},
	{}	/* Terminator */

--
1.7.4.1

maintainer
#1 lore raw
Quoted 3 lines · Radek (Mrkva) Pilař

MMC controller cannot handle MMC_CAP_4_BIT_DATA nor MMC_CAP_8_BIT_DATA - the card won't be detected (tested with two SDHC cards, both Class6). Thus disabling.

Hmm it might be worth checking that the MMC data lines are muxed correctly. Maybe make sure CONFIG_OMAP_MUX_DEBUG is set in your .config and CONFIG_DEBUG_FS too. Then boot and and mount debugfs with mount -tdebugfs debugfs /sys/kernel/debug. Then you can do:

# grep -i mmc1 /sys/kernel/debug/omap_mux/* | grep dat

And check the settings. Changing the values could cause data corruption, so use a temporary root file system!

Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

Well, MMC_CAP_8BIT data is definetely wrong - according to schematics, there are only D0-D3 (+CLK and CMD) lines connected. I'm going to test 4 BIT and let you know.

Quoted 16 lines · Tony Lindgren
Quoted 3 lines · Radek (Mrkva) Pilař

MMC controller cannot handle MMC_CAP_4_BIT_DATA nor MMC_CAP_8_BIT_DATA - the card won't be detected (tested with two SDHC cards, both Class6). Thus disabling.

Hmm it might be worth checking that the MMC data lines are muxed correctly. Maybe make sure CONFIG_OMAP_MUX_DEBUG is set in your .config and CONFIG_DEBUG_FS too. Then boot and and mount debugfs with mount -tdebugfs debugfs /sys/kernel/debug. Then you can do:

# grep -i mmc1 /sys/kernel/debug/omap_mux/* | grep dat

And check the settings. Changing the values could cause data corruption, so use a temporary root file system!

Quoted 6 lines

Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html