dbri driver cleanup
PATCH 1/1 dbri driver cleanup
This is a small clean up of the dbri driver for sparc machines.
It contains also a fix to DBRI interrupt queue initialization.
---
This is the first patch for the dbri driver. I plan to rework this driver at least to the level of OSS dbri driver (16-bit stereo PCM and no annoying noises during playback).
Regards,
Krzysztof Helt
----------------------------------------------------
Gooorące Last Minute! Egipt, Tunezja, Turcja... Kliknij i zarezerwuj:
http://klik.wp.pl/?adr=http%3A%2F%2Fwycieczki.pasaz.wp.pl&sid=844
sound/sparc/dbri.c renamed from alsa-kernel/sparc/dbri.c +5 -11
@@ -104,17 +104,15 @@ static char *cmds[] = { #define dprintk(a, x...) if(dbri_debug & a) printk(KERN_DEBUG x) -#define DBRI_CMD (cmd, intr, value) ((cmd << 28) | \ - (1 << 27) | \ - value)#else #define dprintk(a, x...) -#define DBRI_CMD (cmd, intr, value) ((cmd << 28) | \ - (intr << 27) | \ - value)#endif /* DBRI_DEBUG */ +#define DBRI_CMD (cmd, intr, value) ((cmd << 28) | \ + (intr << 27) | \ + value) +/*************************************************************************** CS4215 specific definitions and structures ****************************************************************************/
@@ -690,7 +688,6 @@ static volatile s32 *dbri_cmdlock(structstatic void dbri_cmdsend (struct snd_dbri * dbri,volatile s32 * cmd) {volatile s32 *ptr; -u32 reg;for (ptr = &dbri->dma->cmd[0 ]; ptr < cmd; ptr++) {dprintk (D_CMD ,"cmd: %lx:%08x\n" , (unsigned long )ptr, *ptr);
@@ -709,9 +706,6 @@ static void dbri_cmdsend(struct snd_dbri/* Set command pointer and signal it is valid. */ sbus_writel (dbri->dma_dvma, dbri->regs +REG8 ); - reg =sbus_readl (dbri->regs +REG0 ); - reg |=D_P ; -sbus_writel (reg, dbri->regs +REG0 );/*spin_unlock(&dbri->lock); */ }
@@ -752,7 +746,7 @@ static void dbri_initialize(struct snd_d*/ for (n =0 ; n <DBRI_NO_INTS -1 ; n++) { dma_addr = dbri->dma_dvma; - dma_addr +=dbri_dma_off (intr, ((n +1 ) &DBRI_INT_BLK )); + dma_addr +=dbri_dma_off (intr, ((n +1 ) *DBRI_INT_BLK )); dbri->dma->intr[n *DBRI_INT_BLK ] = dma_addr; } dma_addr = dbri->dma_dvma +dbri_dma_off (intr,0 );
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
At Sun, 13 Aug 2006 16:14:54 +0200,
Quoted 6 lines · Krzysztof Helt
This is a small clean up of the dbri driver for sparc machines.
It contains also a fix to DBRI interrupt queue initialization.
Signed-off-by Krzysztof Helt ([email protected])
Thanks, I applied it together with your second patch to ALSA HG tree.
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642