Skip to contentSkip to conversation

HELP - NETDEV WATCHDOG tx timeouts

DISCUSSION Larry Finger 1 participant 1 message Sep 9, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

In the bcm43xx driver, the code snippet shown below has a problem. When the synchronize_net statement is included, once every 200-300 passes through the code, the system will report a NETDEV WATCHDOG tx timeout for bcm43xx, even when the watchdog timeout is set to 30 sec. When the synchronize statement is removed, there are no errors, Except for lo, this is the only active network device on the system.

Is there something wrong with this structure? How can synchronize_net take that long?

Thanks, Larry

==============

       mutex_lock(...);
       netif_stop_queue(net_device);
       synchronize_net();               <================ problem ?
       spin_lock_irqsave(.....);

...... do some stuff on the hardware
disable interrupts on device
spin_unlock_irqrestore(.......);
synchronize irq top/bottom halves
...... lengthy processing here

       spin_lock_irqsave(.....);
       tasklet_enable(.....);
       enable interrupts
...... more stuff with the hardware
       netif_wake_queue(net_device);
       spin_unlock_irqrestore(...);
       mutex_unlock(...);