Skip to contentSkip to conversation

DVB build fails without I2C

DISCUSSION Jeff Garzik 3 participants 4 messages Sep 9, 2006 – Sep 10, 2006

lore
Share & tools
lore
#0 lore raw

In an effort to speed up my all-filesystems build, I disabled several things in my allyesconfig-generated .config. As luck would have it, I wound up disabling I2C but did not disable DVB.

This led to a link failure at the end of the build, with the linker complaining that many I2C-related symbols were not present.

Recommended solution: Add I2C as a dependency (or select) in DVB Kconfig.

Jeff

#1 lore raw
Quoted 8 lines · Jeff Garzik

In an effort to speed up my all-filesystems build, I disabled several things in my allyesconfig-generated .config. As luck would have it, I wound up disabling I2C but did not disable DVB.

This led to a link failure at the end of the build, with the linker complaining that many I2C-related symbols were not present.

Recommended solution: Add I2C as a dependency (or select) in DVB Kconfig.

DVB-CORE does not depend on I2C, since it does not rely on any I2C at all. (DVB-CORE can use other methods) It is the PCI bridges that depend on I2C. IIRC, we had a patch adding I2C dependencies for the Kconfig for the relevant bridge chips. The frontends which are connected to the bridges, depend on DVB-Core and I2C. So that dependency exists.

frontends foo
depends on DVB_CORE && I2C

pci bridges foo
depends on DVB_CORE && I2C && PCI

Maybe that patch has not made it yet to mainline.

Manu

#2 lore raw

Em Sáb, 2006-09-09 às 19:13 +0400, Manu Abraham escreveu:

Quoted 5 lines
Quoted 1 line · Jeff Garzik

Recommended solution: Add I2C as a dependency (or select) in DVB Kconfig.

DVB-CORE does not depend on I2C, since it does not rely on any I2C at all. (DVB-CORE can use other methods) It is the PCI bridges that depend on I2C.

Yes. There are even a few dvb drivers that doesn't depend on I2C.

Quoted 11 lines

IIRC, we had a patch adding I2C dependencies for the Kconfig for
the relevant bridge chips. The frontends which are connected to the bridges, depend on DVB-Core and I2C. So that dependency exists.

frontends foo
depends on DVB_CORE && I2C

pci bridges foo
depends on DVB_CORE && I2C && PCI

Maybe that patch has not made it yet to mainline.

No, it didn't arrived mainstream. It arrived only -mm series. The patch depends a previous patch that added DVB attach support. Somebody offered to backport it to 2.6.18 at #v4l channel (I'm not sure but I think it was adq).

Cheers,
Mauro.

#3 lore raw

Em Dom, 2006-09-10 às 10:17 -0300, Mauro Carvalho Chehab escreveu:

Quoted 7 lines

Em Sáb, 2006-09-09 às 19:13 +0400, Manu Abraham escreveu:

Quoted 4 lines
Quoted 1 line · Jeff Garzik

Recommended solution: Add I2C as a dependency (or select) in DVB Kconfig.

DVB-CORE does not depend on I2C
Maybe that patch has not made it yet to mainline.

No, it didn't arrived mainstream.
(I'm not sure but I think it was adq).

Yes, it was adq. He sent us a proper patch. I'm testing it the proper patch at the kernel, with allmodconfig, then without i2c. If it works fine, I'll send today to Linus to be included at mainstream.

Cheers,
Mauro.