vnc: drop vnc_colordepth() call.
PATCH 1/1 vnc: drop vnc_colordepth() call.
With gtk-vnc (which supports VNC_FEATURE_WMVI) this results in sending a VNC_ENCODING_WMVi message to the client. Which in turn seems to make gtk-vnc respond with another non-incremental update request. Hello endless loop ...
Drop the call.
--- ui/vnc.c | 1 - 1 file changed, 1 deletion(-)
ui/vnc.c +0 -1
@@ -2041,7 +2041,6 @@ static void framebuffer_update_request(VncState *vs, int incremental, }else { vs->update =VNC_STATE_UPDATE_FORCE ;vnc_set_area_dirty (vs->dirty, vs->vd, x, y, w, h); -vnc_colordepth (vs);vnc_desktop_resize (vs);vnc_led_state_change (vs);vnc_cursor_define (vs);
Signature · 1 line
2.29.2
Hi Gerd,
Quoted 20 lines · Gerd Hoffmann
With gtk-vnc (which supports
VNC_FEATURE_WMVI) this results in sending aVNC_ENCODING_WMVimessage to the client. Which in turn seems to make gtk-vnc respond with another non-incremental update request. Hello endless loop ...Drop the call.
Fixes 9e1632ad07ca ("vnc: move initialization to framebuffer_update_request")Reported-by Laszlo Ersek <[email protected]>Signed-off-by Gerd Hoffmann <[email protected]>--- ui/vnc.c | 1 - 1 file changed, 1 deletion(-)ui/vnc.c +0
-0
ui/vnc.c static void framebuffer_update_request(VncState *vs, int incremental, · line 2046
Quoted 7 lines
ui/vnc.c +0
-1@@ -2041,7 +2041,6 @@ static void framebuffer_update_request(VncState *vs, int incremental, }else { vs->update =VNC_STATE_UPDATE_FORCE ;vnc_set_area_dirty (vs->dirty, vs->vd, x, y, w, h); -vnc_colordepth (vs);vnc_desktop_resize (vs);vnc_led_state_change (vs);vnc_cursor_define (vs);
while this patch has some effect, it does not fix the issue.
* With the gvncviewer binary I mentioned before, there is no change in behavior -- initial screen shown, no updates then, and finally connection dropped:
Quoted 5 lines
Connected to server
Remote desktop size changed to 800x480
Connection initialized
Error: Failed to flush data
Disconnected from server
* With virt-manager, there is a before-after difference: the screen is now *flashing*, between actual content and a black void. Meanwhile the VNC client is still spinning.
* If I pass "--gtk-vnc-debug" to "gvncviewer", the following log snippet keeps repeating:
Quoted 11 lines
src/vncconnection.cEmit main context 8src/vncconnection.cRe-requesting framebuffer update at 0,0 size 640x480, incremental 0src/vncconnection.cNum rects 1src/vncconnection.cFramebufferUpdate type=-223 area (640x480) at location 0,0src/vncconnection.cDesktop resize w=640 h=480src/vncconnection.cEmit main context 5src/vncdisplay.cFramebuffer size / format unchanged, skipping recreatesrc/vncconnection.cRequesting framebuffer update at 0,0 size 640x480, incremental 0src/vncconnection.cNum rects 1src/vncconnection.cFramebufferUpdate type=-261 area (1x1) at location 0,0src/vncconnection.cLED state: 0
Thanks
Laszlo
Quoted 43 lines · Laszlo Ersek
Hi Gerd,
Quoted 20 lines · Gerd Hoffmann
With gtk-vnc (which supports
VNC_FEATURE_WMVI) this results in sending aVNC_ENCODING_WMVimessage to the client. Which in turn seems to make gtk-vnc respond with another non-incremental update request. Hello endless loop ...Drop the call.
Fixes 9e1632ad07ca ("vnc: move initialization to framebuffer_update_request")Reported-by Laszlo Ersek <[email protected]>Signed-off-by Gerd Hoffmann <[email protected]>--- ui/vnc.c | 1 - 1 file changed, 1 deletion(-)ui/vnc.c +0
-0ui/vnc.c static void framebuffer_update_request(VncState *vs, int incremental, · line 2046
Quoted 7 lines
ui/vnc.c +0
-1@@ -2041,7 +2041,6 @@ static void framebuffer_update_request(VncState *vs, int incremental, }else { vs->update =VNC_STATE_UPDATE_FORCE ;vnc_set_area_dirty (vs->dirty, vs->vd, x, y, w, h); -vnc_colordepth (vs);vnc_desktop_resize (vs);vnc_led_state_change (vs);vnc_cursor_define (vs);while this patch has some effect, it does not fix the issue.
* With the gvncviewer binary I mentioned before, there is no change in behavior -- initial screen shown, no updates then, and finally connection dropped:
Quoted 5 lines
Connected to server
Remote desktop size changed to 800x480
Connection initialized
Error: Failed to flush data
Disconnected from server
Quoted 18 lines
* With virt-manager, there is a before-after difference: the screen is now *flashing*, between actual content and a black void. Meanwhile the VNC client is still spinning.
* If I pass "--gtk-vnc-debug" to "gvncviewer", the following log snippet keeps repeating:
Quoted 11 lines
src/vncconnection.cEmit main context 8src/vncconnection.cRe-requesting framebuffer update at 0,0 size 640x480, incremental 0src/vncconnection.cNum rects 1src/vncconnection.cFramebufferUpdate type=-223 area (640x480) at location 0,0src/vncconnection.cDesktop resize w=640 h=480src/vncconnection.cEmit main context 5src/vncdisplay.cFramebuffer size / format unchanged, skipping recreatesrc/vncconnection.cRequesting framebuffer update at 0,0 size 640x480, incremental 0src/vncconnection.cNum rects 1src/vncconnection.cFramebufferUpdate type=-261 area (1x1) at location 0,0src/vncconnection.cLED state: 0
If gtk-vnc sees an update with a psuedo encoding it will re-request the last framebuffer update message.
In this case it had a fb update request with incremental==0 pending, so when seeing the pesudo encoding it re-request incremental==0 again. This triggers a loop in QEMU, because QEMU is unconditionally sending these psuedo-encodings when every non-incremental update.
Once gtk-vnc receives a non-psuedo encoding update, it wil switch to using incremental==1.
The problem is this QEMU code above is sending the psuedo encodings synchronously upon getting the framebuffer update request, and so putting gtk-vnc into a loop, as QEMU nevers gets around to sending the actual framebuffer data which we're expecting.
QEMU needs to only send these psuedo encodings if they reflect something which has changed on the server, rather than sending them unconditionally on every non-incremental update.
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|